diff options
| author | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-26 06:25:07 +0000 |
|---|---|---|
| committer | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-26 06:25:07 +0000 |
| commit | 5fcb32a48c26bbced1dc5989a7196dab39b7d675 (patch) | |
| tree | b3199b581b55ec705caa625bba7a4905ce64a361 /chrome/browser/views/about_chrome_view.cc | |
| parent | 6aaf098b311c05bf560093170508b8c67cd177f8 (diff) | |
| download | chromium_src-5fcb32a48c26bbced1dc5989a7196dab39b7d675.zip chromium_src-5fcb32a48c26bbced1dc5989a7196dab39b7d675.tar.gz chromium_src-5fcb32a48c26bbced1dc5989a7196dab39b7d675.tar.bz2 | |
This CL fix issue 8649 -- RTL: Wrong parenthesis direction is displayed on "About Google Chrome" dialog
(http://crbug.com/8649).
The fix is to adjust the string according to locale,
so that the pure English string in RTL locale is surrounded by left-right-embedding mark for parenthesis to be displayed correctly.
Review URL: http://codereview.chromium.org/42096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12540 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/about_chrome_view.cc')
| -rw-r--r-- | chrome/browser/views/about_chrome_view.cc | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/chrome/browser/views/about_chrome_view.cc b/chrome/browser/views/about_chrome_view.cc index fe9eb5d..0ef4183 100644 --- a/chrome/browser/views/about_chrome_view.cc +++ b/chrome/browser/views/about_chrome_view.cc @@ -761,10 +761,14 @@ void AboutChromeView::UpdateStatus(GoogleUpdateUpgradeResult result, !installed_version->IsHigherThan(running_version.get())) { UserMetrics::RecordAction(L"UpgradeCheck_AlreadyUpToDate", profile_); check_button_status_ = CHECKBUTTON_HIDDEN; - update_label_.SetText( + std::wstring update_label_text = l10n_util::GetStringF(IDS_UPGRADE_ALREADY_UP_TO_DATE, l10n_util::GetString(IDS_PRODUCT_NAME), - current_version_)); + current_version_); + if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) { + update_label_text.push_back(static_cast<wchar_t>(l10n_util::kLeftToRightMark)); + } + update_label_.SetText(update_label_text); show_success_indicator = true; break; } |