diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-15 21:06:25 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-15 21:06:25 +0000 |
commit | e0d481585dfab19c0b01b7518080164fa001d54c (patch) | |
tree | ac4b3d806f6917093c8d1f6319d25381934d7211 /chrome/browser/views/about_chrome_view.cc | |
parent | a4c1eb2d00a9c66b4fc809916081cc727c998414 (diff) | |
download | chromium_src-e0d481585dfab19c0b01b7518080164fa001d54c.zip chromium_src-e0d481585dfab19c0b01b7518080164fa001d54c.tar.gz chromium_src-e0d481585dfab19c0b01b7518080164fa001d54c.tar.bz2 |
Replace a bunch of hardcoded URLs with constants from url_constants.h
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/193092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26263 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/about_chrome_view.cc')
-rw-r--r-- | chrome/browser/views/about_chrome_view.cc | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/chrome/browser/views/about_chrome_view.cc b/chrome/browser/views/about_chrome_view.cc index 923e9bb..6b2ba40 100644 --- a/chrome/browser/views/about_chrome_view.cc +++ b/chrome/browser/views/about_chrome_view.cc @@ -18,6 +18,7 @@ #include "chrome/browser/metrics/user_metrics.h" #include "chrome/browser/views/restart_message_box.h" #include "chrome/common/chrome_constants.h" +#include "chrome/common/url_constants.h" #include "chrome/installer/util/install_util.h" #include "grit/chromium_strings.h" #include "grit/generated_resources.h" @@ -37,10 +38,6 @@ namespace { // the version field doesn't overlap it. const int kVersionFieldWidth = 195; -// The URLs that you navigate to when clicking the links in the About dialog. -const wchar_t* const kAcknowledgements = L"about:credits"; -const wchar_t* const kTOS = L"about:terms"; - // These are used as placeholder text around the links in the text in the about // dialog. const wchar_t* kBeginLink = L"BEGIN_LINK"; @@ -65,7 +62,7 @@ std::wstring StringSubRange(const std::wstring& text, size_t start, namespace browser { -// Declared in browser_dialogs.h so that others don't need to depend on our .h. +// Declared in browser_dialogs.h so that others don't need to depend on our .h. void ShowAboutChromeView(views::Widget* parent, Profile* profile) { views::Window::CreateChromeWindow(parent->GetNativeView(), gfx::Rect(), @@ -699,11 +696,11 @@ void AboutChromeView::LinkActivated(views::Link* source, int event_flags) { GURL url; if (source == terms_of_service_url_) - url = GURL(kTOS); + url = GURL(chrome::kAboutTermsURL); else if (source == chromium_url_) url = GURL(l10n_util::GetString(IDS_CHROMIUM_PROJECT_URL)); else if (source == open_source_url_) - url = GURL(kAcknowledgements); + url = GURL(chrome::kAboutCreditsURL); else NOTREACHED() << "Unknown link source"; |