diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-17 19:04:12 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-17 19:04:12 +0000 |
| commit | afe3a16739185a648a21a34e07f3cdb5f1a23c2f (patch) | |
| tree | 4c82ce550948ed3d67a7a46a1aa066c9080412fb /chrome/browser/views/about_chrome_view.cc | |
| parent | d699e3a52d6431ea5d2a691f77866ac8ec7ba350 (diff) | |
| download | chromium_src-afe3a16739185a648a21a34e07f3cdb5f1a23c2f.zip chromium_src-afe3a16739185a648a21a34e07f3cdb5f1a23c2f.tar.gz chromium_src-afe3a16739185a648a21a34e07f3cdb5f1a23c2f.tar.bz2 | |
Use plain strings instead of wstrings for UMA actions
git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/
This cuts more than 10k off my binary. Which is nothing compared
to the size of the binary, but that's a whole lot of zero bytes!
This is less code this way anyway.
Review URL: http://codereview.chromium.org/399026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/about_chrome_view.cc')
| -rwxr-xr-x | chrome/browser/views/about_chrome_view.cc | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/chrome/browser/views/about_chrome_view.cc b/chrome/browser/views/about_chrome_view.cc index e738067..f86b588 100755 --- a/chrome/browser/views/about_chrome_view.cc +++ b/chrome/browser/views/about_chrome_view.cc @@ -773,19 +773,19 @@ void AboutChromeView::UpdateStatus(GoogleUpdateUpgradeResult result, switch (result) { case UPGRADE_STARTED: - UserMetrics::RecordAction(L"Upgrade_Started", profile_); + UserMetrics::RecordAction("Upgrade_Started", profile_); check_button_status_ = CHECKBUTTON_DISABLED; show_throbber = true; update_label_.SetText(l10n_util::GetString(IDS_UPGRADE_STARTED)); break; case UPGRADE_CHECK_STARTED: - UserMetrics::RecordAction(L"UpgradeCheck_Started", profile_); + UserMetrics::RecordAction("UpgradeCheck_Started", profile_); check_button_status_ = CHECKBUTTON_HIDDEN; show_throbber = true; update_label_.SetText(l10n_util::GetString(IDS_UPGRADE_CHECK_STARTED)); break; case UPGRADE_IS_AVAILABLE: - UserMetrics::RecordAction(L"UpgradeCheck_UpgradeIsAvailable", profile_); + UserMetrics::RecordAction("UpgradeCheck_UpgradeIsAvailable", profile_); check_button_status_ = CHECKBUTTON_ENABLED; update_label_.SetText( l10n_util::GetStringF(IDS_UPGRADE_AVAILABLE, @@ -802,7 +802,7 @@ void AboutChromeView::UpdateStatus(GoogleUpdateUpgradeResult result, installer::Version::GetVersionFromString(current_version_)); if (!installed_version.get() || !installed_version->IsHigherThan(running_version.get())) { - UserMetrics::RecordAction(L"UpgradeCheck_AlreadyUpToDate", profile_); + UserMetrics::RecordAction("UpgradeCheck_AlreadyUpToDate", profile_); check_button_status_ = CHECKBUTTON_HIDDEN; std::wstring update_label_text = l10n_util::GetStringF(IDS_UPGRADE_ALREADY_UP_TO_DATE, @@ -820,9 +820,9 @@ void AboutChromeView::UpdateStatus(GoogleUpdateUpgradeResult result, } case UPGRADE_SUCCESSFUL: { if (result == UPGRADE_ALREADY_UP_TO_DATE) - UserMetrics::RecordAction(L"UpgradeCheck_AlreadyUpgraded", profile_); + UserMetrics::RecordAction("UpgradeCheck_AlreadyUpgraded", profile_); else - UserMetrics::RecordAction(L"UpgradeCheck_Upgraded", profile_); + UserMetrics::RecordAction("UpgradeCheck_Upgraded", profile_); check_button_status_ = CHECKBUTTON_HIDDEN; const std::wstring& update_string = new_version_available_.empty() ? l10n_util::GetStringF(IDS_UPGRADE_SUCCESSFUL_NOVERSION, @@ -836,7 +836,7 @@ void AboutChromeView::UpdateStatus(GoogleUpdateUpgradeResult result, break; } case UPGRADE_ERROR: - UserMetrics::RecordAction(L"UpgradeCheck_Error", profile_); + UserMetrics::RecordAction("UpgradeCheck_Error", profile_); check_button_status_ = CHECKBUTTON_HIDDEN; update_label_.SetText(l10n_util::GetStringF(IDS_UPGRADE_ERROR, IntToWString(error_code))); |