diff options
author | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-31 17:16:26 +0000 |
---|---|---|
committer | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-31 17:16:26 +0000 |
commit | 45003a76537ada4d727e0b33f28961a72938c9e7 (patch) | |
tree | 93d62dd7633fe2165d65c0548c8bcde2006b35db /chrome/browser/views/about_chrome_view.h | |
parent | 153d44b69e23ac6e1ca2efa64ef5544f08cb8c71 (diff) | |
download | chromium_src-45003a76537ada4d727e0b33f28961a72938c9e7.zip chromium_src-45003a76537ada4d727e0b33f28961a72938c9e7.tar.gz chromium_src-45003a76537ada4d727e0b33f28961a72938c9e7.tar.bz2 |
Fix RTL issues in the About box (bug 3756).
I used the BiDiLineIterator, which I moved out of the AutocompletePopup and into the l10n_util file. I also added a wrapper function around ubidi_getLogicalRun.
Review URL: http://codereview.chromium.org/8727
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4294 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/about_chrome_view.h')
-rw-r--r-- | chrome/browser/views/about_chrome_view.h | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/chrome/browser/views/about_chrome_view.h b/chrome/browser/views/about_chrome_view.h index cc29f01..be876a4 100644 --- a/chrome/browser/views/about_chrome_view.h +++ b/chrome/browser/views/about_chrome_view.h @@ -100,13 +100,16 @@ class AboutChromeView : public views::View, const ChromeFont& font); // A helper function for DrawTextAndPositionUrl, which simply draws the text - // from a certain starting point |position| and wraps within bounds. For - // details on the parameters, see DrawTextAndPositionUrl. + // from a certain starting point |position| and wraps within bounds. + // |word_for_word| specifies whether to draw the text word for word or wheter + // to treat the text as one blurb (similar to the way url's are treated inside + // RTL text. For details on the other parameters, see DrawTextAndPositionUrl. void DrawTextStartingFrom(ChromeCanvas* canvas, const std::wstring& text, gfx::Size* position, const gfx::Rect& bounds, - const ChromeFont& font); + const ChromeFont& font, + bool word_for_word); // A simply utility function that calculates whether a word of width // |word_width| fits at position |position| within the |bounds| rectangle. If @@ -162,6 +165,9 @@ class AboutChromeView : public views::View, // The version Google Update reports is available to us. std::wstring new_version_available_; + // Whether text direction is left-to-right or right-to-left. + bool text_direction_is_rtl_; + DISALLOW_COPY_AND_ASSIGN(AboutChromeView); }; |