Small tweaks to improve toolbar keyboard accessibility: Put focus rects

around more controls (including location bar, only when in full keyboard
access mode).  Fix accessible names.  Fix spacebar to activate menu buttons.
Remove methods for child focus, they're not needed anymore.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2817022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50462 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 4 deletions

diff --git a/chrome/browser/views/accessible_toolbar_view.h b/chrome/browser/views/accessible_toolbar_view.h
index 7ecb572..e5beede 100644
--- a/chrome/browser/views/accessible_toolbar_view.h
+++ b/chrome/browser/views/accessible_toolbar_view.h
@@ -31,13 +31,13 @@ class AccessibleToolbarView : public views::View,
   // if the user escapes. If |initial_focus| is not NULL, that control will get
   // the initial focus, if it's enabled and focusable. Returns true if
   // the toolbar was able to receive focus.
-  bool SetToolbarFocus(int view_storage_id, View* initial_focus);
+  virtual bool SetToolbarFocus(int view_storage_id, View* initial_focus);
 
   // Set focus to the toolbar with complete keyboard access, with the
   // focus initially set to the default child. Focus will be restored
   // to the ViewStorage with id |view_storage_id| if the user escapes.
   // Returns true if the toolbar was able to receive focus.
-  bool SetToolbarFocusAndFocusDefault(int view_storage_id);
+  virtual bool SetToolbarFocusAndFocusDefault(int view_storage_id);
 
   // Overridden from views::View:
   virtual FocusTraversable* GetPaneFocusTraversable();
@@ -59,12 +59,13 @@ class AccessibleToolbarView : public views::View,
   // other than the first focusable child.
   virtual views::View* GetDefaultFocusableChild() { return NULL; }
 
+  // Remove toolbar focus.
+  virtual void RemoveToolbarFocus();
+
   // Remove toolbar focus unless a child (including indirect children)
   // still has the focus.
   void RemoveToolbarFocusIfNoChildHasFocus();
 
-  void RemoveToolbarFocus();
-
   void RestoreLastFocusedView();
 
   View* GetFirstFocusableChild();