Makes the chevron throb after a user sync'ed his bookmarks (if the overflow menu is shown)

This also makes the chevron throb when no bookmarks is added during a sync and merge. 

BUG=24306
TEST=sync with over 10 bookmarks in the bookmark bar so that the chevron is visible.

Patch by Bruno Calvignac<BrunoCalvignac@gmail.com>
Original Review: http://codereview.chromium.org/306054/show

Review URL: http://codereview.chromium.org/454010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33379 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 10 insertions, 11 deletions

diff --git a/chrome/browser/views/bookmark_bar_view.h b/chrome/browser/views/bookmark_bar_view.h
index 92efeb8..a9cc397 100644
--- a/chrome/browser/views/bookmark_bar_view.h
+++ b/chrome/browser/views/bookmark_bar_view.h
@@ -210,6 +210,11 @@ class BookmarkBarView : public DetachableToolbarView,
   // Maximum size of buttons on the bookmark bar.
   static const int kMaxButtonWidth;
 
+  // If a button is currently throbbing, it is stopped. If immediate is true
+  // the throb stops immediately, otherwise it stops after a couple more
+  // throbs.
+  void StopThrobbing(bool immediate);
+
   // If true we're running tests. This short circuits a couple of animations.
   static bool testing_;
 
@@ -399,14 +404,11 @@ class BookmarkBarView : public DetachableToolbarView,
   // visible, this returns GetBookmarkButtonCount().
   int GetFirstHiddenNodeIndex();
 
-  // If the bookmark bubble is showing this determines which view should throb
-  // and starts it throbbing. Does nothing if bookmark bubble isn't showing.
-  void StartThrobbing();
-
-  // If a button is currently throbbing, it is stopped. If immediate is true
-  // the throb stops immediately, otherwise it stops after a couple more
-  // throbs.
-  void StopThrobbing(bool immediate);
+  // This determines which view should throb and starts it
+  // throbbing (e.g when the bookmark bubble is showing).
+  // If |overflow_only| is true, start throbbing only if |node| is hidden in
+  // the overflow menu.
+  void StartThrobbing(const BookmarkNode* node, bool overflow_only);
 
   // Updates the colors for all the child objects in the bookmarks bar.
   void UpdateColors();
@@ -478,9 +480,6 @@ class BookmarkBarView : public DetachableToolbarView,
   // Animation controlling showing and hiding of the bar.
   scoped_ptr<SlideAnimation> size_animation_;
 
-  // If the bookmark bubble is showing, this is the URL.
-  GURL bubble_url_;
-
   // If the bookmark bubble is showing, this is the visible ancestor of the URL.
   // The visible ancestor is either the other_bookmarked_button_,
   // overflow_button_ or a button on the bar.