Move a bunch of dialog creation routines to browser_dialogs.h to break the

dependency on the implementations of those views.

This also moves that file into the browser:: namespace to avoid having all the
functions in the global namespace.

Rename the "parent" parameter to ShowHTMLDialog to a NativeWindow type to
avoid nasty casting. I assume this argument was written before we had
NativeWindow.
Review URL: http://codereview.chromium.org/113728

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16743 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 24 insertions, 0 deletions

diff --git a/chrome/browser/views/bookmark_bubble_view.cc b/chrome/browser/views/bookmark_bubble_view.cc
index 94eea8b..d6f0a99 100644
--- a/chrome/browser/views/bookmark_bubble_view.cc
+++ b/chrome/browser/views/bookmark_bubble_view.cc
@@ -47,6 +47,30 @@ static const size_t kMaxMRUFolders = 5;
 // Bubble close image.
 static SkBitmap* kCloseImage = NULL;
 
+// Declared in browser_dialogs.h so callers don't have to depend on our header.
+
+namespace browser {
+
+void ShowBookmarkBubbleView(views::Window* parent,
+                            const gfx::Rect& bounds,
+                            InfoBubbleDelegate* delegate,
+                            Profile* profile,
+                            const GURL& url,
+                            bool newly_bookmarked) {
+  BookmarkBubbleView::Show(parent, bounds, delegate, profile, url,
+                           newly_bookmarked);
+}
+
+void HideBookmarkBubbleView() {
+  BookmarkBubbleView::Hide();
+}
+
+bool IsBookmarkBubbleViewShowing() {
+  return BookmarkBubbleView::IsShowing();
+}
+
+}  // namespace browser
+
 // RecentlyUsedFoldersModel ---------------------------------------------------
 
 BookmarkBubbleView::RecentlyUsedFoldersModel::RecentlyUsedFoldersModel(