summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/bookmark_bubble_view.h
diff options
context:
space:
mode:
authorfinnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-03 20:58:01 +0000
committerfinnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-03 20:58:01 +0000
commita071e653c8e2b9b77c412600c3d35de814541527 (patch)
tree4f6edf175b8090a8140d511b72ae0879fbacfec2 /chrome/browser/views/bookmark_bubble_view.h
parentd78f40f3543cd057d845625d1abce9cd79b0682c (diff)
downloadchromium_src-a071e653c8e2b9b77c412600c3d35de814541527.zip
chromium_src-a071e653c8e2b9b77c412600c3d35de814541527.tar.gz
chromium_src-a071e653c8e2b9b77c412600c3d35de814541527.tar.bz2
Fix 9867: Activating the previous/next buttons with the keyboard in the find bar should not change the focus.
Add param const Event& event to ButtonPressed, so that recipients can find out more about the event that generated the ButtonPress message. BUG=9687 TEST=Open www.google.com and open Find-in-page, search for 'e'. Press FindNext button with mouse and note that the focus should be on the textfield. Now press Tab twice to put focus on the FindNext button and press SpaceBar a few times. Note that the focus should stay on the FindNext button. Review URL: http://codereview.chromium.org/188016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25367 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/bookmark_bubble_view.h')
-rw-r--r--chrome/browser/views/bookmark_bubble_view.h19
1 files changed, 11 insertions, 8 deletions
diff --git a/chrome/browser/views/bookmark_bubble_view.h b/chrome/browser/views/bookmark_bubble_view.h
index 0c1d9e8..83bd517 100644
--- a/chrome/browser/views/bookmark_bubble_view.h
+++ b/chrome/browser/views/bookmark_bubble_view.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -34,12 +34,12 @@ class BookmarkBubbleView : public views::View,
public views::Combobox::Listener,
public InfoBubbleDelegate {
public:
- static void Show(views::Window* window,
- const gfx::Rect& bounds,
- InfoBubbleDelegate* delegate,
- Profile* profile,
- const GURL& url,
- bool newly_bookmarked);
+ static void Show(views::Window* window,
+ const gfx::Rect& bounds,
+ InfoBubbleDelegate* delegate,
+ Profile* profile,
+ const GURL& url,
+ bool newly_bookmarked);
static bool IsShowing();
@@ -105,7 +105,7 @@ class BookmarkBubbleView : public views::View,
virtual void LinkActivated(views::Link* source, int event_flags);
// ButtonListener method, closes the bubble or opens the edit dialog.
- virtual void ButtonPressed(views::Button* sender);
+ virtual void ButtonPressed(views::Button* sender, const views::Event& event);
// Combobox::Listener method. Changes the parent of the bookmark.
virtual void ItemChanged(views::Combobox* combobox,
@@ -122,6 +122,9 @@ class BookmarkBubbleView : public views::View,
// Closes the bubble.
void Close();
+ // Handle the message when the user presses a button.
+ void HandleButtonPressed(views::Button* sender);
+
// Shows the BookmarkEditor.
void ShowEditor();