diff options
| author | dantasse@chromium.org <dantasse@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-10 17:40:09 +0000 |
|---|---|---|
| committer | dantasse@chromium.org <dantasse@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-10 17:40:09 +0000 |
| commit | 1fcca9babb9af32eb06907b4389f55fcc0147337 (patch) | |
| tree | 7913db3edb6dd024b1939b3c05935ddf15ad85d5 /chrome/browser/views/bookmark_manager_view.cc | |
| parent | 1717246fe78714112ebb4c7b581b8d49a2d34c44 (diff) | |
| download | chromium_src-1fcca9babb9af32eb06907b4389f55fcc0147337.zip chromium_src-1fcca9babb9af32eb06907b4389f55fcc0147337.tar.gz chromium_src-1fcca9babb9af32eb06907b4389f55fcc0147337.tar.bz2 | |
Fix for bug 26397: Bookmark manager in Incognito mode doesn't show Sync Bookmarks button
The bug exists because the BookmarkManagerView checks the profile to see if it has a ProfileSyncService set up to see whether it should show the "Sync Bookmarks" button. Incognito profiles do not have a ProfileSyncService, even if the corresponding "original profile" has a PSS. So the fix is to check the original profile (here called "profile_"), not the profile.
This is already fixed in Linux (bookmark_manager_gtk.cc). Also, all native versions are scheduled to be replaced by a common bookmark manager soon.
BUG=26397
TEST=manual
Review URL: http://codereview.chromium.org/574022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38625 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/bookmark_manager_view.cc')
| -rw-r--r-- | chrome/browser/views/bookmark_manager_view.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/views/bookmark_manager_view.cc b/chrome/browser/views/bookmark_manager_view.cc index 18e9fb2..7e8c8d3 100644 --- a/chrome/browser/views/bookmark_manager_view.cc +++ b/chrome/browser/views/bookmark_manager_view.cc @@ -242,7 +242,7 @@ BookmarkManagerView::BookmarkManagerView(Profile* profile) if (!bookmark_model->IsLoaded()) bookmark_model->AddObserver(this); - if (profile->GetProfileSyncService()) { + if (profile_->GetProfileSyncService()) { sync_service_ = profile_->GetProfileSyncService(); sync_service_->AddObserver(this); UpdateSyncStatus(); |