diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-23 01:02:38 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-23 01:02:38 +0000 |
| commit | f554832167558b7f4810883b59aeb73b8f79114f (patch) | |
| tree | 002509ec0af088e08588bb2eb6e4ee8274beed77 /chrome/browser/views/bookmark_manager_view.h | |
| parent | 905ec55d6d282074a5b927c10404c864ed3f144a (diff) | |
| download | chromium_src-f554832167558b7f4810883b59aeb73b8f79114f.zip chromium_src-f554832167558b7f4810883b59aeb73b8f79114f.tar.gz chromium_src-f554832167558b7f4810883b59aeb73b8f79114f.tar.bz2 | |
The TableViewObserver::OnKeyDown method signature was changed recently and
the bookmark manager view had not been properly updated and was not called
anymore, breaking the keyboard shortcuts.
This was broken in the TaskManager as well.
Also changed the TreeView to use the base::KeyboardCode.
BUG=25533
TEST=Test that the different shortcuts (CTRL-X,CTRL-V, CTRL-C, DELETE,
ENTER...) work in the bookmark manager.
Test that in the TaskManager, pressing ENTER activates the selected tab.
Review URL: http://codereview.chromium.org/322006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29854 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/bookmark_manager_view.h')
| -rw-r--r-- | chrome/browser/views/bookmark_manager_view.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/chrome/browser/views/bookmark_manager_view.h b/chrome/browser/views/bookmark_manager_view.h index 608b8c7..37bc746 100644 --- a/chrome/browser/views/bookmark_manager_view.h +++ b/chrome/browser/views/bookmark_manager_view.h @@ -5,6 +5,7 @@ #ifndef CHROME_BROWSER_VIEWS_BOOKMARK_MANAGER_VIEW_H_ #define CHROME_BROWSER_VIEWS_BOOKMARK_MANAGER_VIEW_H_ +#include "base/keyboard_codes.h" #include "base/ref_counted.h" #include "base/task.h" #include "chrome/browser/bookmarks/bookmark_model_observer.h" @@ -112,11 +113,11 @@ class BookmarkManagerView : public views::View, virtual void OnDoubleClick(); virtual void OnMiddleClick(); virtual void OnTableViewDelete(views::TableView* table); - virtual void OnKeyDown(unsigned short virtual_keycode); + virtual void OnKeyDown(base::KeyboardCode keycode); // TreeViewController methods. virtual void OnTreeViewSelectionChanged(views::TreeView* tree_view); - virtual void OnTreeViewKeyDown(unsigned short virtual_keycode); + virtual void OnTreeViewKeyDown(base::KeyboardCode keycode); #if defined(BROWSER_SYNC) // views::ButtonListener method. |