diff options
| author | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-24 02:47:40 +0000 |
|---|---|---|
| committer | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-24 02:47:40 +0000 |
| commit | 46ebf0640d32b313618fe443a34e959059b2c3f9 (patch) | |
| tree | 84b616ce5385bce6c8d4b966e74daf7648fdc8c5 /chrome/browser/views/bookmark_menu_controller_views.h | |
| parent | 7c543fd101874d1453dfcf9727dd0d39d296ef50 (diff) | |
| download | chromium_src-46ebf0640d32b313618fe443a34e959059b2c3f9.zip chromium_src-46ebf0640d32b313618fe443a34e959059b2c3f9.tar.gz chromium_src-46ebf0640d32b313618fe443a34e959059b2c3f9.tar.bz2 | |
Add undeclared virtual destructors.
Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.
r=jar
Review URL: http://codereview.chromium.org/2856051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53570 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/bookmark_menu_controller_views.h')
| -rw-r--r-- | chrome/browser/views/bookmark_menu_controller_views.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/chrome/browser/views/bookmark_menu_controller_views.h b/chrome/browser/views/bookmark_menu_controller_views.h index 511483a..f858bfd 100644 --- a/chrome/browser/views/bookmark_menu_controller_views.h +++ b/chrome/browser/views/bookmark_menu_controller_views.h @@ -43,6 +43,9 @@ class BookmarkMenuController : public BaseBookmarkModelObserver, class Observer { public: virtual void BookmarkMenuDeleted(BookmarkMenuController* controller) = 0; + + protected: + virtual ~Observer() {} }; // Creates a BookmarkMenuController showing the children of |node| starting @@ -121,7 +124,7 @@ class BookmarkMenuController : public BaseBookmarkModelObserver, typedef std::map<const BookmarkNode*, int> NodeToMenuIDMap; // BookmarkMenuController deletes itself as necessary. - ~BookmarkMenuController(); + virtual ~BookmarkMenuController(); // Creates a menu and adds it to node_to_menu_id_map_. This uses // BuildMenu to recursively populate the menu. |