diff options
| author | twiz@google.com <twiz@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-03 17:20:57 +0000 |
|---|---|---|
| committer | twiz@google.com <twiz@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-03 17:20:57 +0000 |
| commit | ccb686dd5e4c4e1b60109f7110badd78f8e76300 (patch) | |
| tree | 4f554d1fedbec8a577b051e6da8364e975233dd0 /chrome/browser/views/browser_actions_container.h | |
| parent | 9fa8af659705465662679b7663aa501b5cdb0861 (diff) | |
| download | chromium_src-ccb686dd5e4c4e1b60109f7110badd78f8e76300.zip chromium_src-ccb686dd5e4c4e1b60109f7110badd78f8e76300.tar.gz chromium_src-ccb686dd5e4c4e1b60109f7110badd78f8e76300.tar.bz2 | |
A very basic fix that prevents experimental popups from living longer than the ExtensionFunctionDispatcher/RenderViewHost that launched the popup. This is a problem, for example, when Chrome is closed while a popup is still displayed.
I also removed the code that delayed sending the onClosed popup notification. I modified the ExtensionPopup::Obeserver interface to add methods for about-to-close, and fully-closed notifications.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/2092020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48841 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/browser_actions_container.h')
| -rw-r--r-- | chrome/browser/views/browser_actions_container.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/views/browser_actions_container.h b/chrome/browser/views/browser_actions_container.h index a4334f3..918a927 100644 --- a/chrome/browser/views/browser_actions_container.h +++ b/chrome/browser/views/browser_actions_container.h @@ -350,7 +350,7 @@ class BrowserActionsContainer virtual void InspectPopup(ExtensionAction* action); // Overriden from ExtensionPopup::Delegate - virtual void ExtensionPopupClosed(ExtensionPopup* popup); + virtual void ExtensionPopupIsClosing(ExtensionPopup* popup); // Moves a browser action with |id| to |new_index|. void MoveBrowserAction(const std::string& extension_id, size_t new_index); |