diff options
| author | erikkay@chromium.org <erikkay@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-18 21:42:19 +0000 |
|---|---|---|
| committer | erikkay@chromium.org <erikkay@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-18 21:42:19 +0000 |
| commit | 0f320ca605db3ab928ee1a8f57ff4c6ea195b021 (patch) | |
| tree | 0139f0fe9531653f5b9f22a2706dc6ff7438d7c1 /chrome/browser/views/browser_bubble.cc | |
| parent | 7fcb792736cc10cc20a84cce7fe6f7c5d2470bf9 (diff) | |
| download | chromium_src-0f320ca605db3ab928ee1a8f57ff4c6ea195b021.zip chromium_src-0f320ca605db3ab928ee1a8f57ff4c6ea195b021.tar.gz chromium_src-0f320ca605db3ab928ee1a8f57ff4c6ea195b021.tar.bz2 | |
Change BrowserBubble to use Close instead of CloseNow. This should make
it less susceptible to crashes in certain use cases.
Remove a delay in destroying the widget that was added to work around
the old crash.
BUG=18248
TEST=none
Review URL: http://codereview.chromium.org/211027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26625 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/browser_bubble.cc')
| -rw-r--r-- | chrome/browser/views/browser_bubble.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/views/browser_bubble.cc b/chrome/browser/views/browser_bubble.cc index de6959b..42a3e7f 100644 --- a/chrome/browser/views/browser_bubble.cc +++ b/chrome/browser/views/browser_bubble.cc @@ -24,7 +24,8 @@ BrowserBubble::BrowserBubble(views::View* view, views::Widget* frame, BrowserBubble::~BrowserBubble() { DCHECK(!attached_); - popup_->CloseNow(); + popup_->Close(); + // Don't call DetachFromBrowser from here. It needs to talk to the // BrowserView to deregister itself, and if BrowserBubble is owned // by a child of BrowserView, then it's possible that this stack frame |