diff options
author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-02 01:48:35 +0000 |
---|---|---|
committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-02 01:48:35 +0000 |
commit | 74f34b094a7b21f0c057f493abee5db30b988592 (patch) | |
tree | f3e7e9169b46331718e9ae7932f9108644dee0db /chrome/browser/views/browser_bubble.h | |
parent | 17b4f9a87ce73e5f6d87c21c5b593cbd23f797fa (diff) | |
download | chromium_src-74f34b094a7b21f0c057f493abee5db30b988592.zip chromium_src-74f34b094a7b21f0c057f493abee5db30b988592.tar.gz chromium_src-74f34b094a7b21f0c057f493abee5db30b988592.tar.bz2 |
Make sure we don't dismiss extension popups when the focus
changes for a child window of the popup, as it is the case
with select popups.
BUG=28110
TEST=Make sure extension popups are still working as expected.
Open an extension popup with a select popup (combo box)
in it. Click on the select to bring up its popup, the
extension popup should stay opened.
Review URL: http://codereview.chromium.org/459005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33533 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/browser_bubble.h')
-rw-r--r-- | chrome/browser/views/browser_bubble.h | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/chrome/browser/views/browser_bubble.h b/chrome/browser/views/browser_bubble.h index eaf3d0b..f796a22 100644 --- a/chrome/browser/views/browser_bubble.h +++ b/chrome/browser/views/browser_bubble.h @@ -29,7 +29,10 @@ class BrowserBubble { virtual void BubbleGotFocus(BrowserBubble* bubble) {} // Called when the bubble became inactive / lost focus. - virtual void BubbleLostFocus(BrowserBubble* bubble) {} + // |focused_view| is the NativeView getting the focus, it may be NULL if the + // popup was closed programatically. + virtual void BubbleLostFocus(BrowserBubble* bubble, + gfx::NativeView focused_view) {} }; // Note that the bubble will size itself to the preferred size of |view|. @@ -81,6 +84,9 @@ class BrowserBubble { // Resize the bubble to fit the view. void ResizeToView(); + // Returns the NativeView containing that popup. + gfx::NativeView native_view() const { return frame_native_view_; } + protected: // Create the popup widget. virtual void InitPopup(); |