diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-08 23:38:16 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-08 23:38:16 +0000 |
| commit | 05d47875219edd6f25490d8a878021ff2d564170 (patch) | |
| tree | 88fe8a3aaa158da3dd6acbb20258ab604a93ce56 /chrome/browser/views/bug_report_view.h | |
| parent | 43101c0334b3297868085e661a2e92f935434a5e (diff) | |
| download | chromium_src-05d47875219edd6f25490d8a878021ff2d564170.zip chromium_src-05d47875219edd6f25490d8a878021ff2d564170.tar.gz chromium_src-05d47875219edd6f25490d8a878021ff2d564170.tar.bz2 | |
When the Find bar has focus it eats keypresses such as PageUp, PageDown and Up and Down arrow keys. It doesn't need to - instead the page should scroll even if focus is on the Find bar.
This patch forwards those selected keypresses to the page for its perusal.
Known issues: Just like Firefox, the page doesn't scroll if it has frames.
SONG=I like to fixit fixit. I like to fixit fixit.
BUG=7079
TEST=Open FindInPage on a webpage that has a vertical scrollbar. Press Down, Up, PageDown and PageUp and the page should scroll accordingly. Make sure no ding is heard while doing so. Also make sure this works if focus is on a textfield/textarea when you press Ctrl+F.
Review URL: http://codereview.chromium.org/62129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13389 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/bug_report_view.h')
| -rw-r--r-- | chrome/browser/views/bug_report_view.h | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/chrome/browser/views/bug_report_view.h b/chrome/browser/views/bug_report_view.h index de3e4b4..22a2c42 100644 --- a/chrome/browser/views/bug_report_view.h +++ b/chrome/browser/views/bug_report_view.h @@ -1,9 +1,9 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2009 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_VIEWS_BUGREPORT_VIEW_H_ -#define CHROME_BROWSER_VIEWS_BUGREPORT_VIEW_H_ +#ifndef CHROME_BROWSER_VIEWS_BUG_REPORT_VIEW_H_ +#define CHROME_BROWSER_VIEWS_BUG_REPORT_VIEW_H_ #include "chrome/browser/net/url_fetcher.h" #include "chrome/views/controls/combo_box.h" @@ -52,7 +52,7 @@ class BugReportView : public views::View, // views::TextField::Controller implementation: virtual void ContentsChanged(views::TextField* sender, const std::wstring& new_contents); - virtual void HandleKeystroke(views::TextField* sender, + virtual bool HandleKeystroke(views::TextField* sender, UINT message, TCHAR key, UINT repeat_count, UINT flags); @@ -120,7 +120,7 @@ class BugReportView : public views::View, // their original text so they don't have to type it again. std::wstring old_report_text_; - DISALLOW_EVIL_CONSTRUCTORS(BugReportView); + DISALLOW_COPY_AND_ASSIGN(BugReportView); }; -#endif // CHROME_BROWSER_VIEWS_BUGREPORT_VIEW_H_ +#endif // CHROME_BROWSER_VIEWS_BUG_REPORT_VIEW_H_ |