diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-21 03:43:45 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-21 03:43:45 +0000 |
| commit | eea372e5ae883c1a9853086e54b43896aa72df36 (patch) | |
| tree | f8345aa56206a072496d69554f805fe189483011 /chrome/browser/views/bug_report_view.h | |
| parent | b343f1c73ce201d34fe41037734f57f68dffe2f6 (diff) | |
| download | chromium_src-eea372e5ae883c1a9853086e54b43896aa72df36.zip chromium_src-eea372e5ae883c1a9853086e54b43896aa72df36.tar.gz chromium_src-eea372e5ae883c1a9853086e54b43896aa72df36.tar.bz2 | |
Try to make TextField::Controller implementors cross-platform by abstracting
away the keystroke message that is passed. It turns out implementoars only ever
check for enter and escape messages, so I wrote two functions in TextField
that will decode the new Keyboard event.
This design is not optimal. Ideally we would have something more like the
WebInputEvent so that callers can check for anything in a cross-platform way.
This was branched off from the original review:
http://codereview.chromium.org/113639
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16577 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/bug_report_view.h')
| -rw-r--r-- | chrome/browser/views/bug_report_view.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/chrome/browser/views/bug_report_view.h b/chrome/browser/views/bug_report_view.h index 0688a1dc..9edf1f0 100644 --- a/chrome/browser/views/bug_report_view.h +++ b/chrome/browser/views/bug_report_view.h @@ -53,8 +53,7 @@ class BugReportView : public views::View, virtual void ContentsChanged(views::TextField* sender, const std::wstring& new_contents); virtual bool HandleKeystroke(views::TextField* sender, - UINT message, TCHAR key, - UINT repeat_count, UINT flags); + const views::TextField::Keystroke& key); // views::ComboBox::Listener implementation: virtual void ItemChanged(views::ComboBox* combo_box, int prev_index, |