diff options
author | beng@google.com <beng@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-07-30 04:12:18 +0000 |
---|---|---|
committer | beng@google.com <beng@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-07-30 04:12:18 +0000 |
commit | 0f2f4b60511540e292e085ba5e1985be6bf93908 (patch) | |
tree | 6d6bb042fe78bb23c4eca3cf4a4222a3dab38e74 /chrome/browser/views/bug_report_view.h | |
parent | aaeb9dc745d49afa66c1b613daa5a3123f309955 (diff) | |
download | chromium_src-0f2f4b60511540e292e085ba5e1985be6bf93908.zip chromium_src-0f2f4b60511540e292e085ba5e1985be6bf93908.tar.gz chromium_src-0f2f4b60511540e292e085ba5e1985be6bf93908.tar.bz2 |
Window Delegate Improvements:
- Windows now must have a Delegate. Just construct the default WindowDelegate
if
you don't want to have to write one in testing.
- Windows now obtain their contents view by asking the delegate via
WindowDelegate::GetContentsView.
- Contents views no longer need to manually store a pointer to the Window that
contains them, WindowDelegate does this automatically via its window()
accessor.
Reviewer notes:
- review window_delegate.h first, then
- window.h/cc
- custom frame window.h/cc
- constrained_window_impl.h/cc
- then everything else (just updating all call sites)
B=1280060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/bug_report_view.h')
-rw-r--r-- | chrome/browser/views/bug_report_view.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/chrome/browser/views/bug_report_view.h b/chrome/browser/views/bug_report_view.h index f50e63c..07919d3 100644 --- a/chrome/browser/views/bug_report_view.h +++ b/chrome/browser/views/bug_report_view.h @@ -67,7 +67,6 @@ class BugReportView : public ChromeViews::View, explicit BugReportView(Profile* profile, TabContents* tab); virtual ~BugReportView(); - void set_dialog(ChromeViews::Window* dialog) { dialog_ = dialog; } void set_version(const std::wstring& version) { version_ = version; } // NOTE: set_png_data takes ownership of the vector void set_png_data(std::vector<unsigned char> *png_data) { @@ -98,6 +97,7 @@ class BugReportView : public ChromeViews::View, virtual bool IsModal() const; virtual std::wstring GetWindowTitle() const; virtual bool Accept(); + virtual ChromeViews::View* GetContentsView(); void SetUrl(const GURL& url); @@ -129,7 +129,6 @@ class BugReportView : public ChromeViews::View, ChromeViews::CheckBox* include_page_image_checkbox_; scoped_ptr<BugReportComboBoxModel> bug_type_model_; - ChromeViews::Window* dialog_; Profile* profile_; |