diff options
author | darin@google.com <darin@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-03 18:18:14 +0000 |
---|---|---|
committer | darin@google.com <darin@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-03 18:18:14 +0000 |
commit | 2d31666a58e746b7a1d415c99e5f68ad9256d236 (patch) | |
tree | 144c99d4b80df0f0f9a3ded83f9d21a8b36f17cc /chrome/browser/views/download_item_view.cc | |
parent | 90d6958fe2374a00d3c8583cf4d3b8a509ae8e90 (diff) | |
download | chromium_src-2d31666a58e746b7a1d415c99e5f68ad9256d236.zip chromium_src-2d31666a58e746b7a1d415c99e5f68ad9256d236.tar.gz chromium_src-2d31666a58e746b7a1d415c99e5f68ad9256d236.tar.bz2 |
Minor cleanup to OneShotTimer and RepeatingTimer: moves more of the member variables into the Task subclass.
Also included in this change: deprecate MessageLoop::timer_manager(), and change consumers over to use OneShotTimer or RepeatingTimer.
R=beng
BUG=1346553
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1684 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/download_item_view.cc')
-rw-r--r-- | chrome/browser/views/download_item_view.cc | 21 |
1 files changed, 5 insertions, 16 deletions
diff --git a/chrome/browser/views/download_item_view.cc b/chrome/browser/views/download_item_view.cc index 923752e..bde72f2 100644 --- a/chrome/browser/views/download_item_view.cc +++ b/chrome/browser/views/download_item_view.cc @@ -46,8 +46,6 @@ DownloadItemView::DownloadItemView(DownloadItem* download, parent_(parent), model_(model), progress_angle_(download_util::kStartAngleDegrees), - progress_timer_(NULL), - progress_task_(NULL), body_state_(NORMAL), drop_down_state_(NORMAL), drop_down_pressed_(false), @@ -175,24 +173,15 @@ void DownloadItemView::UpdateDownloadProgress() { } void DownloadItemView::StartDownloadProgress() { - if (progress_task_ || progress_timer_) + if (progress_timer_.IsRunning()) return; - progress_task_ = - new download_util::DownloadProgressTask<DownloadItemView>(this); - progress_timer_ = - MessageLoop::current()->timer_manager()-> - StartTimer(download_util::kProgressRateMs, progress_task_, true); + progress_timer_.Start( + TimeDelta::FromMilliseconds(download_util::kProgressRateMs), this, + &DownloadItemView::UpdateDownloadProgress); } void DownloadItemView::StopDownloadProgress() { - if (progress_timer_) { - DCHECK(progress_task_); - MessageLoop::current()->timer_manager()->StopTimer(progress_timer_); - delete progress_timer_; - progress_timer_ = NULL; - delete progress_task_; - progress_task_ = NULL; - } + progress_timer_.Stop(); } // DownloadObserver interface |