diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-09 17:56:16 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-09 17:56:16 +0000 |
| commit | 01ba6d347ce84345b729131f27e48a1732aac83c (patch) | |
| tree | ca6518ef0d3f9503431e04ea783ffa7095568ca5 /chrome/browser/views/find_bar_host_gtk.cc | |
| parent | cd4a83858ee51f7c8a0f9afb0f378b5bbd4e5098 (diff) | |
| download | chromium_src-01ba6d347ce84345b729131f27e48a1732aac83c.zip chromium_src-01ba6d347ce84345b729131f27e48a1732aac83c.tar.gz chromium_src-01ba6d347ce84345b729131f27e48a1732aac83c.tar.bz2 | |
When a GtkWidget was destroyed the NVH would not be detached.
There was a hack in location_bar_view to prevent an assert, but it would cause an other assert.
Also fixed a double delete with the find_bar_host.
BUG=None
TEST=Start Chrome Linux toolkit view. Close it. It should not assert.
Review URL: http://codereview.chromium.org/266034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28556 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/find_bar_host_gtk.cc')
| -rwxr-xr-x | chrome/browser/views/find_bar_host_gtk.cc | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/chrome/browser/views/find_bar_host_gtk.cc b/chrome/browser/views/find_bar_host_gtk.cc index 6b05f92..e517407 100755 --- a/chrome/browser/views/find_bar_host_gtk.cc +++ b/chrome/browser/views/find_bar_host_gtk.cc @@ -24,7 +24,10 @@ void FindBarHost::AudibleAlert() { } views::Widget* FindBarHost::CreateHost() { - return new views::WidgetGtk(views::WidgetGtk::TYPE_CHILD); + views::WidgetGtk* host = new views::WidgetGtk(views::WidgetGtk::TYPE_CHILD); + // We own the host. + host->set_delete_on_destroy(false); + return host; } void FindBarHost::SetDialogPositionNative(const gfx::Rect& new_pos, |