diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-30 18:48:00 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-30 18:48:00 +0000 |
| commit | 82166b65c8cdd7cb855c2d018be8c6c815324af6 (patch) | |
| tree | f96034ed91ce66d6a3ba2afa07cdd4be1e55b264 /chrome/browser/views/find_bar_win_browsertest.cc | |
| parent | 7811b768ff61d58153a198a273cdb39581a77542 (diff) | |
| download | chromium_src-82166b65c8cdd7cb855c2d018be8c6c815324af6.zip chromium_src-82166b65c8cdd7cb855c2d018be8c6c815324af6.tar.gz chromium_src-82166b65c8cdd7cb855c2d018be8c6c815324af6.tar.bz2 | |
This CL removes the last (major) Windows specific part out of the focus manager.
It was previously landed and reverted because it broke the reliability tests.
http://codereview.chromium.org/125148
The breakage was caused by constrained windows not getting a hold of the FocusManager when in unparented tabs.
The fix is to ensure unparented tab still have a way to access their FocusManager for proper closure.
Files changed from the previous patch that need reviewing:
native_tab_contents_container_win.cc
tab_contents_view_win.h
tab_contents_view_win.cc
BUG=None
TEST=Run all tests (unit, ui, interactive). Extensively test the focus in Chrome.
Review URL: http://codereview.chromium.org/146093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19617 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/find_bar_win_browsertest.cc')
| -rw-r--r-- | chrome/browser/views/find_bar_win_browsertest.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/chrome/browser/views/find_bar_win_browsertest.cc b/chrome/browser/views/find_bar_win_browsertest.cc index 6b4c265..de66f7a 100644 --- a/chrome/browser/views/find_bar_win_browsertest.cc +++ b/chrome/browser/views/find_bar_win_browsertest.cc @@ -573,8 +573,9 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, AcceleratorRestoring) { GURL url = server->TestServerPageW(kSimplePage); ui_test_utils::NavigateToURL(browser(), url); - views::FocusManager* focus_manager = views::FocusManager::GetFocusManager( - browser()->window()->GetNativeHandle()); + gfx::NativeView browser_view = browser()->window()->GetNativeHandle(); + views::FocusManager* focus_manager = + views::FocusManager::GetFocusManagerForNativeView(browser_view); // See where Escape is registered. views::Accelerator escape(VK_ESCAPE, false, false, false); |