summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/find_bar_win_uitest.cc
diff options
context:
space:
mode:
authorbrettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-10-21 18:08:09 +0000
committerbrettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-10-21 18:08:09 +0000
commit6fd1a4e2374a8b2bcfe1a65b1be0bebcd1a5f6d4 (patch)
tree3f720a2dfb4632b9474992c59a3e822c60d9dd7b /chrome/browser/views/find_bar_win_uitest.cc
parent666cc51ce6f60ef72284e20b3bc9e0cb2e397ec5 (diff)
downloadchromium_src-6fd1a4e2374a8b2bcfe1a65b1be0bebcd1a5f6d4.zip
chromium_src-6fd1a4e2374a8b2bcfe1a65b1be0bebcd1a5f6d4.tar.gz
chromium_src-6fd1a4e2374a8b2bcfe1a65b1be0bebcd1a5f6d4.tar.bz2
Fix a timing problem that caused the find bar's coordinates to be incorrect.
The visible flag was getting set twice from two different sources, one of which was wrong. Review URL: http://codereview.chromium.org/7820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3666 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/find_bar_win_uitest.cc')
-rw-r--r--chrome/browser/views/find_bar_win_uitest.cc5
1 files changed, 0 insertions, 5 deletions
diff --git a/chrome/browser/views/find_bar_win_uitest.cc b/chrome/browser/views/find_bar_win_uitest.cc
index 0e04274..7844a55 100644
--- a/chrome/browser/views/find_bar_win_uitest.cc
+++ b/chrome/browser/views/find_bar_win_uitest.cc
@@ -155,11 +155,6 @@ TEST_F(FindInPageControllerTest, FindMovesOnTabClose_Issue1343052) {
// Open the Find window and wait for it to animate.
fprintf(stderr, "OpenFindInPage in A\n");
EXPECT_TRUE(tabA->OpenFindInPage());
- // TODO(brettw) fix this! It appears that WaitForFindWindowFullyVisible is
- // broken somehow, and we're getting incorrect values here, probably as a
- // result of the animation. Waiting some extra time seems to make this test
- // pass.
- Sleep(1000);
fprintf(stderr, "WaitForWindowFullyVisible in A\n");
EXPECT_TRUE(WaitForFindWindowFullyVisible(tabA.get()));