diff options
| author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-28 21:19:53 +0000 |
|---|---|---|
| committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-28 21:19:53 +0000 |
| commit | d7ef11bbc6ea0545ab00e29fe006a2e1de29dde9 (patch) | |
| tree | c4e96e45ee51017d02cc5705191ebe0e01659e7c /chrome/browser/views/frame/browser_frame_gtk.h | |
| parent | d766882c913b272cc2db478d7640a317d838ebad (diff) | |
| download | chromium_src-d7ef11bbc6ea0545ab00e29fe006a2e1de29dde9.zip chromium_src-d7ef11bbc6ea0545ab00e29fe006a2e1de29dde9.tar.gz chromium_src-d7ef11bbc6ea0545ab00e29fe006a2e1de29dde9.tar.bz2 | |
Change the way the NonClientView handles forcing the native frame for popups/app windows.
Rather than carrying state in a force_native_frame_ member it uses a virtual method AlwaysUseNativeFrame analogous to AlwaysUseCustomFrame. This makes me a little happier.
BUG=none
TEST=On a vista capable system, test that when a theme is installed, popups and app frames are rendered with the native frame. Test that constrained windows (e.g. HTTP basic auth) are rendered with the custom frame. Without a theme installed, test that all windows have a native frame except constrained windows. With Vista Basic system setting, verify that all windows have a custom frame, including constrained windows.
Review URL: http://codereview.chromium.org/200146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27413 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/frame/browser_frame_gtk.h')
| -rw-r--r-- | chrome/browser/views/frame/browser_frame_gtk.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/chrome/browser/views/frame/browser_frame_gtk.h b/chrome/browser/views/frame/browser_frame_gtk.h index 75ec308..5b8a561 100644 --- a/chrome/browser/views/frame/browser_frame_gtk.h +++ b/chrome/browser/views/frame/browser_frame_gtk.h @@ -24,7 +24,7 @@ class BrowserFrameGtk : public BrowserFrame, // separate to avoid recursive calling of the frame from its constructor. void Init(); - // BrowserFrame implementation. + // Overridden from BrowserFrame: virtual views::Window* GetWindow(); virtual void TabStripCreated(TabStripWrapper* tabstrip); virtual int GetMinimizeButtonOffset() const; @@ -32,14 +32,15 @@ class BrowserFrameGtk : public BrowserFrame, virtual void UpdateThrobber(bool running); virtual void ContinueDraggingDetachedTab(); virtual ThemeProvider* GetThemeProviderForFrame() const; + virtual bool AlwaysUseNativeFrame() const; - // Overridden from views::Widget. + // Overridden from views::Widget: virtual ThemeProvider* GetThemeProvider() const; virtual ThemeProvider* GetDefaultThemeProvider() const; virtual void IsActiveChanged(); protected: - // WidgetGtk overrides. + // Overridden from views::WidgetGtk: virtual views::RootView* CreateRootView(); private: |