diff options
author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-03 20:58:01 +0000 |
---|---|---|
committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-03 20:58:01 +0000 |
commit | a071e653c8e2b9b77c412600c3d35de814541527 (patch) | |
tree | 4f6edf175b8090a8140d511b72ae0879fbacfec2 /chrome/browser/views/frame | |
parent | d78f40f3543cd057d845625d1abce9cd79b0682c (diff) | |
download | chromium_src-a071e653c8e2b9b77c412600c3d35de814541527.zip chromium_src-a071e653c8e2b9b77c412600c3d35de814541527.tar.gz chromium_src-a071e653c8e2b9b77c412600c3d35de814541527.tar.bz2 |
Fix 9867: Activating the previous/next buttons with the keyboard in the find bar should not change the focus.
Add param const Event& event to ButtonPressed, so that recipients can find out more about the event that generated the ButtonPress message.
BUG=9687
TEST=Open www.google.com and open Find-in-page, search for 'e'. Press FindNext button with mouse and note that the focus should be on the textfield. Now press Tab twice to put focus on the FindNext button and press SpaceBar a few times. Note that the focus should stay on the FindNext button.
Review URL: http://codereview.chromium.org/188016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25367 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/frame')
-rw-r--r-- | chrome/browser/views/frame/opaque_browser_frame_view.cc | 3 | ||||
-rw-r--r-- | chrome/browser/views/frame/opaque_browser_frame_view.h | 2 |
2 files changed, 3 insertions, 2 deletions
diff --git a/chrome/browser/views/frame/opaque_browser_frame_view.cc b/chrome/browser/views/frame/opaque_browser_frame_view.cc index 13fb540..0bbdc7d 100644 --- a/chrome/browser/views/frame/opaque_browser_frame_view.cc +++ b/chrome/browser/views/frame/opaque_browser_frame_view.cc @@ -421,7 +421,8 @@ void OpaqueBrowserFrameView::SetAccessibleName(const std::wstring& name) { /////////////////////////////////////////////////////////////////////////////// // OpaqueBrowserFrameView, views::ButtonListener implementation: -void OpaqueBrowserFrameView::ButtonPressed(views::Button* sender) { +void OpaqueBrowserFrameView::ButtonPressed( + views::Button* sender, const views::Event& event) { views::Window* window = frame_->GetWindow(); if (sender == minimize_button_) window->Minimize(); diff --git a/chrome/browser/views/frame/opaque_browser_frame_view.h b/chrome/browser/views/frame/opaque_browser_frame_view.h index 3f71560..81d2b36 100644 --- a/chrome/browser/views/frame/opaque_browser_frame_view.h +++ b/chrome/browser/views/frame/opaque_browser_frame_view.h @@ -59,7 +59,7 @@ class OpaqueBrowserFrameView : public BrowserNonClientFrameView, virtual void SetAccessibleName(const std::wstring& name); // Overridden from views::ButtonListener: - virtual void ButtonPressed(views::Button* sender); + virtual void ButtonPressed(views::Button* sender, const views::Event& event); // Overridden from TabIconView::TabIconViewModel: virtual bool ShouldTabIconViewAnimate() const; |