[accessibility] Bookmarks bar is missing some MSAA information

Return the link role for the Link view.

Return the grouping role for BookmarkBarInstructionsView.

Support the link role in views accessibility types.

Updated browser views accessibility tests.
- Verify BrowserRootView accessibility info.
- Verify BrowserView accessibility info.
- Verify BookmarkBarView accessibility info.
- In TestViewAccessibilityObject don't SetAccessible name, we should be testing that this name is correctly set.

Set the accessible name for the application in BrowserRootView instead of OpaqueBrowserFrameView

BUG=36281
TEST=Verify bookmarks bar tree in AccExplorer32.exe 

Review URL: http://codereview.chromium.org/652156

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41744 0039d316-1c4b-4281-b951-d872f2087c98

3 files changed, 3 insertions, 13 deletions

diff --git a/chrome/browser/views/frame/browser_root_view.cc b/chrome/browser/views/frame/browser_root_view.cc
index 7d8e2a1..d789b94 100644
--- a/chrome/browser/views/frame/browser_root_view.cc
+++ b/chrome/browser/views/frame/browser_root_view.cc
@@ -5,6 +5,7 @@
 #include "chrome/browser/views/frame/browser_root_view.h"
 
 #include "app/drag_drop_types.h"
+#include "app/l10n_util.h"
 #include "app/os_exchange_data.h"
 #include "chrome/browser/location_bar.h"
 #include "chrome/browser/profile.h"
@@ -12,12 +13,14 @@
 #include "chrome/browser/views/frame/browser_view.h"
 #include "chrome/browser/views/frame/browser_frame.h"
 #include "chrome/browser/views/tabs/tab_strip.h"
+#include "grit/chromium_strings.h"
 
 BrowserRootView::BrowserRootView(BrowserView* browser_view,
                                  views::Widget* widget)
     : views::RootView(widget),
       browser_view_(browser_view),
       forwarding_to_tab_strip_(false) {
+  SetAccessibleName(l10n_util::GetString(IDS_PRODUCT_NAME));
 }
 
 bool BrowserRootView::GetDropFormats(
diff --git a/chrome/browser/views/frame/opaque_browser_frame_view.cc b/chrome/browser/views/frame/opaque_browser_frame_view.cc
index 4c02944..35c9e91 100644
--- a/chrome/browser/views/frame/opaque_browser_frame_view.cc
+++ b/chrome/browser/views/frame/opaque_browser_frame_view.cc
@@ -389,16 +389,6 @@ bool OpaqueBrowserFrameView::HitTest(const gfx::Point& l) const {
   return browser_view_->IsPositionInWindowCaption(browser_view_point);
 }
 
-void OpaqueBrowserFrameView::ViewHierarchyChanged(bool is_add,
-                                                  views::View* parent,
-                                                  views::View* child) {
-  if (is_add && child == this) {
-    // The Accessibility glue looks for the product name on these two views to
-    // determine if this is in fact a Chrome window.
-    GetRootView()->SetAccessibleName(l10n_util::GetString(IDS_PRODUCT_NAME));
-  }
-}
-
 bool OpaqueBrowserFrameView::GetAccessibleRole(AccessibilityTypes::Role* role) {
   DCHECK(role);
 
diff --git a/chrome/browser/views/frame/opaque_browser_frame_view.h b/chrome/browser/views/frame/opaque_browser_frame_view.h
index 395264e..2c3bdee 100644
--- a/chrome/browser/views/frame/opaque_browser_frame_view.h
+++ b/chrome/browser/views/frame/opaque_browser_frame_view.h
@@ -51,9 +51,6 @@ class OpaqueBrowserFrameView : public BrowserNonClientFrameView,
   virtual void Paint(gfx::Canvas* canvas);
   virtual void Layout();
   virtual bool HitTest(const gfx::Point& l) const;
-  virtual void ViewHierarchyChanged(bool is_add,
-                                    views::View* parent,
-                                    views::View* child);
   virtual bool GetAccessibleRole(AccessibilityTypes::Role* role);
   virtual bool GetAccessibleName(std::wstring* name);
   virtual void SetAccessibleName(const std::wstring& name);