diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-15 18:08:49 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-15 18:08:49 +0000 |
| commit | c398981aa94189d9173b304e5b1d67f97e79fbc8 (patch) | |
| tree | a76be0ddc0038b3e9c2d28736e351fc0117e1320 /chrome/browser/views/go_button.h | |
| parent | 8aa31e5bb274abd6f5eb43e6297e00cf6d365856 (diff) | |
| download | chromium_src-c398981aa94189d9173b304e5b1d67f97e79fbc8.zip chromium_src-c398981aa94189d9173b304e5b1d67f97e79fbc8.tar.gz chromium_src-c398981aa94189d9173b304e5b1d67f97e79fbc8.tar.bz2 | |
Fix regression I introduced where Stop/Go button would toggle state instantly instead of having protections against accidental user actions while the mouse was hovering the button.
I elected to condense ChangeMode() and ScheduleChangeMode() into one function, which as a result became pretty simple.
BUG=9843
Review URL: http://codereview.chromium.org/67156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13761 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/go_button.h')
| -rw-r--r-- | chrome/browser/views/go_button.h | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/chrome/browser/views/go_button.h b/chrome/browser/views/go_button.h index cdd5bea..61b528e 100644 --- a/chrome/browser/views/go_button.h +++ b/chrome/browser/views/go_button.h @@ -32,12 +32,9 @@ class GoButton : public views::ToggleImageButton, GoButton(LocationBarView* location_bar, Browser* Browser); virtual ~GoButton(); - // Force the button state - void ChangeMode(Mode mode); - - // Ask for a specified button state. This is commonly called by the Browser - // when page load state changes. - void ScheduleChangeMode(Mode mode); + // Ask for a specified button state. If |force| is true this will be applied + // immediately. + void ChangeMode(Mode mode, bool force); // Overridden from views::ButtonListener: virtual void ButtonPressed(views::Button* button); |