diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-25 16:49:26 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-25 16:49:26 +0000 |
| commit | 28065f66296d0d012aa5b02c147f4f77ef8a771e (patch) | |
| tree | 9fc2567cd9a4edaf09a322e2465b8540787c118c /chrome/browser/views/info_bubble.cc | |
| parent | 120e1f1b2728ae5d1d4fed21bddb3533b921fdba (diff) | |
| download | chromium_src-28065f66296d0d012aa5b02c147f4f77ef8a771e.zip chromium_src-28065f66296d0d012aa5b02c147f4f77ef8a771e.tar.gz chromium_src-28065f66296d0d012aa5b02c147f4f77ef8a771e.tar.bz2 | |
Use the system WINDOWTEXT color for labels, instead of black. Also use the system WINDOW color for InfoBubbles, not white. Several places are made to explicitly use black labels where that's correct or respecting system colors is a non-trivial fix (bugs filed for most).
Also, apparently I didn't get all my cleanup changes in the last patch, oops.
BUG=92,21027
TEST=Set theme to high-contrast black on white, check that most pieces of chrome UI have readable text
Review URL: http://codereview.chromium.org/237005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27196 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/info_bubble.cc')
| -rw-r--r-- | chrome/browser/views/info_bubble.cc | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/chrome/browser/views/info_bubble.cc b/chrome/browser/views/info_bubble.cc index 92dd6f7..40244ef 100644 --- a/chrome/browser/views/info_bubble.cc +++ b/chrome/browser/views/info_bubble.cc @@ -14,18 +14,15 @@ #include "views/widget/root_view.h" #include "views/window/window.h" -namespace { - // Background color of the bubble. #if defined(OS_WIN) -const SkColor kBackgroundColor = color_utils::GetSysSkColor(COLOR_WINDOW); +const SkColor InfoBubble::kBackgroundColor = + color_utils::GetSysSkColor(COLOR_WINDOW); #else // TODO(beng): source from theme provider. -const SkColor kBackgroundColor = SK_ColorWHITE; +const SkColor InfoBubble::kBackgroundColor = SK_ColorWHITE; #endif -} - // BorderContents ------------------------------------------------------------- // This is used to paint the border of the InfoBubble. Windows uses this via @@ -75,7 +72,7 @@ void BorderContents::InitAndGetBounds( // Set the border. BubbleBorder* bubble_border = new BubbleBorder; set_border(bubble_border); - bubble_border->set_background_color(kBackgroundColor); + bubble_border->set_background_color(InfoBubble::kBackgroundColor); // Give the contents a margin. gfx::Size local_contents_size(contents_size); @@ -128,7 +125,7 @@ void BorderContents::Paint(gfx::Canvas* canvas) { SkPaint paint; paint.setAntiAlias(true); paint.setStyle(SkPaint::kFill_Style); - paint.setColor(kBackgroundColor); + paint.setColor(InfoBubble::kBackgroundColor); gfx::Path path; gfx::Rect bounds(GetLocalBounds(false)); SkRect rect; |