diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-14 04:28:07 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-14 04:28:07 +0000 |
| commit | ca13d804c304a61711352044022971ec39f9d4f8 (patch) | |
| tree | 81e2f1039a317a4ba5177ec98d18a545c0ff9c94 /chrome/browser/views/location_bar_view.h | |
| parent | 921515182691bf105b404862bf80ae7dfc0e151e (diff) | |
| download | chromium_src-ca13d804c304a61711352044022971ec39f9d4f8.zip chromium_src-ca13d804c304a61711352044022971ec39f9d4f8.tar.gz chromium_src-ca13d804c304a61711352044022971ec39f9d4f8.tar.bz2 | |
Clean-up of the accelerator code.
The View::CanProcessTabKeyEvents and View::ShouldLookUpAccelerator have both been replaced with a new method, SkipDefaultKeyEventProcessing.
This new method provides for a view that has focus a way to prevent a key event from being processed for tab traversal or accelerators.
Also, fixed a regression where the Ctrl-Tab accelerator was not working anymore when the omnibox was focused.
BUG=11538
TEST=Thoroughly test accelerators, making sure they work when the page, the omnibox and the find-bar text-field have focus.
Also test that tab traversal still work as expected in the browser and in the option dialog.
Review URL: http://codereview.chromium.org/113307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16037 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/location_bar_view.h')
| -rw-r--r-- | chrome/browser/views/location_bar_view.h | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/chrome/browser/views/location_bar_view.h b/chrome/browser/views/location_bar_view.h index a6ea987..4c30b4b 100644 --- a/chrome/browser/views/location_bar_view.h +++ b/chrome/browser/views/location_bar_view.h @@ -83,9 +83,6 @@ class LocationBarView : public LocationBar, // No focus border for the location bar, the caret is enough. virtual void PaintFocusBorder(ChromeCanvas* canvas) { } - // Overridden from View so we can use <tab> to go into keyword search mode. - virtual bool CanProcessTabKeyEvents(); - // Called when any ancestor changes its size, asks the AutocompleteEditModel // to close its popup. virtual void VisibleBoundsInRootChanged(); @@ -136,7 +133,7 @@ class LocationBarView : public LocationBar, void Focus(); // Overridden from Chrome::View. - virtual bool ShouldLookupAccelerators(const views::KeyEvent& e); + virtual bool SkipDefaultKeyEventProcessing(const views::KeyEvent& event); private: // View used when the user has selected a keyword. |