diff options
author | hbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-22 17:10:11 +0000 |
---|---|---|
committer | hbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-22 17:10:11 +0000 |
commit | 3a5d9e3058e8a8677355c937671225a5929c95ed (patch) | |
tree | 123f51d4a47500e28218986e286f269eb83c1f2e /chrome/browser/views/options/advanced_page_view.cc | |
parent | ac48694e5fac3a7c18d82155ae62f55f9af656f2 (diff) | |
download | chromium_src-3a5d9e3058e8a8677355c937671225a5929c95ed.zip chromium_src-3a5d9e3058e8a8677355c937671225a5929c95ed.tar.gz chromium_src-3a5d9e3058e8a8677355c937671225a5929c95ed.tar.bz2 |
- Passing correct window handle to CreateChromeWindow(). We should pass the
handle of "Fonts and Languages" window to the function, but currently, a handle
of a widget inside the window is passed.
- Remove GetRootWindow() method from options_page_view.h since the function
returns HWND and thus isn't portable. We can simply use
GetWindow()->GetNativeWindow() instead.
BUG=10923
TEST=Open "Languages" dialog (Options - Minor Tweaks - Change font and language
settings - Languages tab - Add), then press Alt+Tab to switch to an another
application, press Alt+Tab again to switch back to chromium, press "Cancel" on
the dialog and verify that the "Fonts and Languages" window is focused.
Original patch created by Yusuke Sato. http://codereview.chromium.org/93097
R=me,ben
Review URL: http://codereview.chromium.org/115687
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16749 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/options/advanced_page_view.cc')
-rw-r--r-- | chrome/browser/views/options/advanced_page_view.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/views/options/advanced_page_view.cc b/chrome/browser/views/options/advanced_page_view.cc index c20ecad..4d4ccad 100644 --- a/chrome/browser/views/options/advanced_page_view.cc +++ b/chrome/browser/views/options/advanced_page_view.cc @@ -157,7 +157,8 @@ void AdvancedPageView::ResetToDefaults() { void AdvancedPageView::ButtonPressed(views::Button* sender) { if (sender == reset_to_default_button_) { UserMetricsRecordAction(L"Options_ResetToDefaults", NULL); - ResetDefaultsConfirmBox::ShowConfirmBox(GetRootWindow(), this); + ResetDefaultsConfirmBox::ShowConfirmBox( + GetWindow()->GetNativeWindow(), this); } } |