summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/options
diff options
context:
space:
mode:
authorben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-06 19:19:05 +0000
committerben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-06 19:19:05 +0000
commit7237402696b827997b0a1a340a44bdc994ed1403 (patch)
tree48e488b07cc79ccd3d218647dc4b5a0bcf92280d /chrome/browser/views/options
parent5fd3aa4f25bb6c56dcd3069e98cf8f97c709bead (diff)
downloadchromium_src-7237402696b827997b0a1a340a44bdc994ed1403.zip
chromium_src-7237402696b827997b0a1a340a44bdc994ed1403.tar.gz
chromium_src-7237402696b827997b0a1a340a44bdc994ed1403.tar.bz2
Test to see if we can reduce some crashes by deferring delegate destruction until WM_NCDESTROY. This involves adding a specific method to allow delegates to destroy themselves to WindowDelegate, and moving all delete this calls into implementations of that method (to allow delegates to still respond to WM_DESTROY which is legit).
Review URL: http://codereview.chromium.org/40192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11132 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/options')
-rw-r--r--chrome/browser/views/options/advanced_page_view.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/views/options/advanced_page_view.cc b/chrome/browser/views/options/advanced_page_view.cc
index 1d4c2ee..b04f975 100644
--- a/chrome/browser/views/options/advanced_page_view.cc
+++ b/chrome/browser/views/options/advanced_page_view.cc
@@ -58,7 +58,7 @@ class ResetDefaultsConfirmBox : public views::DialogDelegate {
return true;
}
// views::WindowDelegate
- virtual void WindowClosing() { delete this; }
+ virtual void DeleteDelegate() { delete this; }
virtual bool IsModal() const { return true; }
virtual views::View* GetContentsView() { return message_box_view_; }