diff options
| author | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-06 07:46:37 +0000 |
|---|---|---|
| committer | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-06 07:46:37 +0000 |
| commit | 3e377c5a80be45d36a6015c80d9e2dae525cf042 (patch) | |
| tree | 089f72c86a2f2314e527f2e95a3903253fbcf51a /chrome/browser/views/options | |
| parent | a42d22a1abe11d4f138c4c0870568be69bad5301 (diff) | |
| download | chromium_src-3e377c5a80be45d36a6015c80d9e2dae525cf042.zip chromium_src-3e377c5a80be45d36a6015c80d9e2dae525cf042.tar.gz chromium_src-3e377c5a80be45d36a6015c80d9e2dae525cf042.tar.bz2 | |
Revert of r22559.
This caused an easily reproducible crash:
1. Start with a fresh profile
2. Navigate to google.com
3. Restart
4. Navigate to google.com
5. crash
The change from pass-by-value to pass-by-ref in
fav_icon_helper.* seems to be to blame, but I can't see it
right off.
TBR=phajdan.jr@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/options')
| -rw-r--r-- | chrome/browser/views/options/general_page_view.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/views/options/general_page_view.cc b/chrome/browser/views/options/general_page_view.cc index f8c1dce..e99444d 100644 --- a/chrome/browser/views/options/general_page_view.cc +++ b/chrome/browser/views/options/general_page_view.cc @@ -106,7 +106,7 @@ class CustomHomePagesTableModel : public TableModel { bool know_fav_icon, scoped_refptr<RefCountedBytes> image_data, bool is_expired, - const GURL& icon_url); + GURL icon_url); // Returns the entry whose fav_icon_handle matches handle and sets entry_index // to the index of the entry. @@ -230,7 +230,7 @@ void CustomHomePagesTableModel::OnGotFavIcon( bool know_fav_icon, scoped_refptr<RefCountedBytes> image_data, bool is_expired, - const GURL& icon_url) { + GURL icon_url) { int entry_index; Entry* entry = GetEntryByLoadHandle(handle, &entry_index); DCHECK(entry); |