summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/options
diff options
context:
space:
mode:
authorben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-20 06:37:01 +0000
committerben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-20 06:37:01 +0000
commit7cf1b6ced3b14cce1d66ca0ddc713851f0d37536 (patch)
tree1c2fc9f4d52bf3046addf820d5eec03a2e150749 /chrome/browser/views/options
parentf9f4841b14a9f309ce5ee613f0d4de6afad88767 (diff)
downloadchromium_src-7cf1b6ced3b14cce1d66ca0ddc713851f0d37536.zip
chromium_src-7cf1b6ced3b14cce1d66ca0ddc713851f0d37536.tar.gz
chromium_src-7cf1b6ced3b14cce1d66ca0ddc713851f0d37536.tar.bz2
Move RTL related functions from app/l10n_util to base/i18n/rtl
TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/options')
-rw-r--r--chrome/browser/views/options/advanced_contents_view.cc11
-rw-r--r--chrome/browser/views/options/passwords_page_view.cc7
2 files changed, 10 insertions, 8 deletions
diff --git a/chrome/browser/views/options/advanced_contents_view.cc b/chrome/browser/views/options/advanced_contents_view.cc
index ab09db9..e7dcfa8 100644
--- a/chrome/browser/views/options/advanced_contents_view.cc
+++ b/chrome/browser/views/options/advanced_contents_view.cc
@@ -17,6 +17,7 @@
#include "app/l10n_util.h"
#include "app/resource_bundle.h"
#include "base/file_util.h"
+#include "base/i18n/rtl.h"
#include "base/message_loop.h"
#include "base/path_service.h"
#include "base/thread.h"
@@ -146,9 +147,9 @@ FileDisplayArea::~FileDisplayArea() {
void FileDisplayArea::SetFile(const FilePath& file_path) {
// Force file path to have LTR directionality.
- if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) {
+ if (base::i18n::IsRTL()) {
string16 localized_file_path;
- l10n_util::WrapPathWithLTRFormatting(file_path, &localized_file_path);
+ base::i18n::WrapPathWithLTRFormatting(file_path, &localized_file_path);
text_field_->SetText(UTF16ToWide(localized_file_path));
} else {
text_field_->SetText(file_path.ToWStringHack());
@@ -210,7 +211,7 @@ void FileDisplayArea::InitClass() {
// We'd prefer to use UILayoutIsRightToLeft() to perform the RTL
// environment check, but it's nonstatic, so, instead, we check whether the
// locale is RTL.
- bool ui_is_rtl = l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT;
+ bool ui_is_rtl = base::i18n::IsRTL();
ResourceBundle& rb = ResourceBundle::GetSharedInstance();
default_folder_icon_ = *rb.GetBitmapNamed(ui_is_rtl ?
IDR_FOLDER_CLOSED_RTL :
@@ -756,7 +757,7 @@ void WebContentSection::ButtonPressed(
void WebContentSection::InitControlLayout() {
AdvancedSection::InitControlLayout();
- if (l10n_util::GetTextDirection() == l10n_util::LEFT_TO_RIGHT) {
+ if (!base::i18n::IsRTL()) {
gears_label_ = new views::Label(
l10n_util::GetString(IDS_OPTIONS_GEARSSETTINGS_GROUP_NAME));
} else {
@@ -765,7 +766,7 @@ void WebContentSection::InitControlLayout() {
std::wstring gearssetting_group_name =
l10n_util::GetString(IDS_OPTIONS_GEARSSETTINGS_GROUP_NAME);
gearssetting_group_name.push_back(
- static_cast<wchar_t>(l10n_util::kRightToLeftMark));
+ static_cast<wchar_t>(base::i18n::kRightToLeftMark));
gears_label_ = new views::Label(gearssetting_group_name);
}
gears_settings_button_ = new views::NativeButton(
diff --git a/chrome/browser/views/options/passwords_page_view.cc b/chrome/browser/views/options/passwords_page_view.cc
index 0cff819..c03700f 100644
--- a/chrome/browser/views/options/passwords_page_view.cc
+++ b/chrome/browser/views/options/passwords_page_view.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/views/options/passwords_page_view.h"
#include "app/l10n_util.h"
+#include "base/i18n/rtl.h"
#include "base/string_util.h"
#include "chrome/browser/password_manager/password_store.h"
#include "chrome/browser/pref_service.h"
@@ -71,16 +72,16 @@ std::wstring PasswordsTableModel::GetText(int row,
case IDS_PASSWORDS_PAGE_VIEW_SITE_COLUMN: { // Site.
const std::wstring& url = saved_signons_[row]->display_url.display_url();
// Force URL to have LTR directionality.
- if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) {
+ if (base::i18n::IsRTL()) {
std::wstring localized_url = url;
- l10n_util::WrapStringWithLTRFormatting(&localized_url);
+ base::i18n::WrapStringWithLTRFormatting(&localized_url);
return localized_url;
}
return url;
}
case IDS_PASSWORDS_PAGE_VIEW_USERNAME_COLUMN: { // Username.
std::wstring username = GetPasswordFormAt(row)->username_value;
- l10n_util::AdjustStringForLocaleDirection(username, &username);
+ base::i18n::AdjustStringForLocaleDirection(username, &username);
return username;
}
default: