diff options
| author | paulg@google.com <paulg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-30 20:02:36 +0000 |
|---|---|---|
| committer | paulg@google.com <paulg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-30 20:02:36 +0000 |
| commit | 23b357b59e5eb192d6c747c9ff19c3d91e1556e1 (patch) | |
| tree | 7c4673aee2b8fe7748e409cd7a2aa71dae67a951 /chrome/browser/views/options | |
| parent | 808f640d6ef38a1d879ecfeff30a1c0aae6f9427 (diff) | |
| download | chromium_src-23b357b59e5eb192d6c747c9ff19c3d91e1556e1.zip chromium_src-23b357b59e5eb192d6c747c9ff19c3d91e1556e1.tar.gz chromium_src-23b357b59e5eb192d6c747c9ff19c3d91e1556e1.tar.bz2 | |
Remove Windows "Save As" dialogs from Save Page code.In this change:- convert SavePackage to use async SelectFileDialog- return the chosen filter index in the FileSelected callback- some clean up of save_package.ccBUG=8691 (http://crbug.com/8691)
Review URL: http://codereview.chromium.org/45048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12799 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/options')
| -rw-r--r-- | chrome/browser/views/options/content_page_view.cc | 5 | ||||
| -rw-r--r-- | chrome/browser/views/options/content_page_view.h | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/chrome/browser/views/options/content_page_view.cc b/chrome/browser/views/options/content_page_view.cc index e6d6e40..4072111 100644 --- a/chrome/browser/views/options/content_page_view.cc +++ b/chrome/browser/views/options/content_page_view.cc @@ -194,7 +194,8 @@ ContentPageView::~ContentPageView() { //////////////////////////////////////////////////////////////////////////////// // ContentPageView, SelectFileDialog::Listener implementation: -void ContentPageView::FileSelected(const std::wstring& path, void* params) { +void ContentPageView::FileSelected(const std::wstring& path, + int index, void* params) { UserMetricsRecordAction(L"Options_SetDownloadDirectory", profile()->GetPrefs()); default_download_location_.SetValue(path); @@ -215,7 +216,7 @@ void ContentPageView::ButtonPressed(views::Button* sender) { dialog_title, profile()->GetPrefs()->GetString( prefs::kDownloadDefaultDirectory), - std::wstring(), std::wstring(), + std::wstring(), 0, std::wstring(), GetRootWindow(), NULL); } else if (sender == download_ask_for_save_location_checkbox_) { diff --git a/chrome/browser/views/options/content_page_view.h b/chrome/browser/views/options/content_page_view.h index 508b568..f7b6b28 100644 --- a/chrome/browser/views/options/content_page_view.h +++ b/chrome/browser/views/options/content_page_view.h @@ -34,7 +34,7 @@ class ContentPageView : public OptionsPageView, virtual void ButtonPressed(views::Button* sender); // SelectFileDialog::Listener implementation: - virtual void FileSelected(const std::wstring& path, void* params); + virtual void FileSelected(const std::wstring& path, int index, void* params); // OptionsPageView implementation: virtual bool CanClose() const; |