summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/options
diff options
context:
space:
mode:
authorbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-31 02:36:23 +0000
committerbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-31 02:36:23 +0000
commite80daf62322d8494212abacd6c810eddef59b2be (patch)
tree6d338dab3602fe38d94a98d690948e9ce2e92ecc /chrome/browser/views/options
parent6e9b3df82a13faebedf10cfca50392f8d909d71b (diff)
downloadchromium_src-e80daf62322d8494212abacd6c810eddef59b2be.zip
chromium_src-e80daf62322d8494212abacd6c810eddef59b2be.tar.gz
chromium_src-e80daf62322d8494212abacd6c810eddef59b2be.tar.bz2
Split out the views table functions into separate header files. Many users only
need either the view or model observers and that's it. I moved the model constructors to a .cc file so we don't have to include l10n_util.h for everybody. A surprising number of files were getting l10n_util from the table code, so I had to add it in a bunch of places. There should be no code change except I made the table column cosntructors take wstring references instead of copies. Review URL: http://codereview.chromium.org/115969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17295 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/options')
-rw-r--r--chrome/browser/views/options/advanced_contents_view.cc1
-rw-r--r--chrome/browser/views/options/cookies_view.cc1
-rw-r--r--chrome/browser/views/options/cookies_view.h8
-rw-r--r--chrome/browser/views/options/exceptions_page_view.h1
-rw-r--r--chrome/browser/views/options/general_page_view.h1
-rw-r--r--chrome/browser/views/options/languages_page_view.cc3
-rw-r--r--chrome/browser/views/options/languages_page_view.h2
-rw-r--r--chrome/browser/views/options/passwords_page_view.h2
8 files changed, 16 insertions, 3 deletions
diff --git a/chrome/browser/views/options/advanced_contents_view.cc b/chrome/browser/views/options/advanced_contents_view.cc
index aa3974b..792370ba 100644
--- a/chrome/browser/views/options/advanced_contents_view.cc
+++ b/chrome/browser/views/options/advanced_contents_view.cc
@@ -13,6 +13,7 @@
#include <vssym32.h>
#include "app/gfx/canvas.h"
+#include "app/l10n_util.h"
#include "app/resource_bundle.h"
#include "base/file_util.h"
#include "base/path_service.h"
diff --git a/chrome/browser/views/options/cookies_view.cc b/chrome/browser/views/options/cookies_view.cc
index 797ae34..30b1e9d 100644
--- a/chrome/browser/views/options/cookies_view.cc
+++ b/chrome/browser/views/options/cookies_view.cc
@@ -23,6 +23,7 @@
#include "views/grid_layout.h"
#include "views/controls/label.h"
#include "views/controls/button/native_button.h"
+#include "views/controls/table/table_model.h"
#include "views/controls/table/table_view.h"
#include "views/controls/textfield/textfield.h"
#include "views/standard_layout.h"
diff --git a/chrome/browser/views/options/cookies_view.h b/chrome/browser/views/options/cookies_view.h
index 521dc7f..997841d 100644
--- a/chrome/browser/views/options/cookies_view.h
+++ b/chrome/browser/views/options/cookies_view.h
@@ -7,16 +7,20 @@
#include "base/task.h"
#include "views/controls/button/button.h"
-#include "views/controls/table/table_view.h"
+#include "views/controls/table/table_view_observer.h"
#include "views/controls/textfield/textfield.h"
#include "views/view.h"
#include "views/window/dialog_delegate.h"
#include "views/window/window.h"
namespace views {
+
class Label;
class NativeButton;
-}
+class TableView;
+
+} // namespace views
+
class CookieInfoView;
class CookiesTableModel;
class CookiesTableView;
diff --git a/chrome/browser/views/options/exceptions_page_view.h b/chrome/browser/views/options/exceptions_page_view.h
index e0abe67..7a2906b 100644
--- a/chrome/browser/views/options/exceptions_page_view.h
+++ b/chrome/browser/views/options/exceptions_page_view.h
@@ -7,6 +7,7 @@
#include "chrome/browser/views/options/options_page_view.h"
#include "chrome/browser/views/options/passwords_page_view.h"
+#include "views/controls/table/table_view_observer.h"
class Profile;
diff --git a/chrome/browser/views/options/general_page_view.h b/chrome/browser/views/options/general_page_view.h
index 077c2f3..a75fb99 100644
--- a/chrome/browser/views/options/general_page_view.h
+++ b/chrome/browser/views/options/general_page_view.h
@@ -10,6 +10,7 @@
#include "chrome/common/pref_member.h"
#include "views/controls/combo_box.h"
#include "views/controls/button/button.h"
+#include "views/controls/table/table_view_observer.h"
#include "views/view.h"
namespace views {
diff --git a/chrome/browser/views/options/languages_page_view.cc b/chrome/browser/views/options/languages_page_view.cc
index 817bdac..48932f9 100644
--- a/chrome/browser/views/options/languages_page_view.cc
+++ b/chrome/browser/views/options/languages_page_view.cc
@@ -31,6 +31,9 @@
#include "views/controls/button/radio_button.h"
#include "views/controls/combo_box.h"
#include "views/controls/tabbed_pane.h"
+#include "views/controls/table/table_model.h"
+#include "views/controls/table/table_model_observer.h"
+#include "views/controls/table/table_view.h"
#include "views/grid_layout.h"
#include "views/standard_layout.h"
#include "views/widget/widget.h"
diff --git a/chrome/browser/views/options/languages_page_view.h b/chrome/browser/views/options/languages_page_view.h
index 308df34..b0ad138 100644
--- a/chrome/browser/views/options/languages_page_view.h
+++ b/chrome/browser/views/options/languages_page_view.h
@@ -9,7 +9,7 @@
#include "chrome/common/pref_member.h"
#include "views/controls/combo_box.h"
#include "views/controls/button/button.h"
-#include "views/controls/table/table_view.h"
+#include "views/controls/table/table_view_observer.h"
#include "views/view.h"
namespace views {
diff --git a/chrome/browser/views/options/passwords_page_view.h b/chrome/browser/views/options/passwords_page_view.h
index 2fd9e46..35cb31e 100644
--- a/chrome/browser/views/options/passwords_page_view.h
+++ b/chrome/browser/views/options/passwords_page_view.h
@@ -15,6 +15,8 @@
#include "views/controls/button/native_button.h"
#include "views/controls/label.h"
#include "views/controls/table/table_view.h"
+#include "views/controls/table/table_model.h"
+#include "views/controls/table/table_view_observer.h"
#include "views/window/dialog_delegate.h"
#include "views/window/window.h"
#include "webkit/glue/password_form.h"