diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-29 00:33:35 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-29 00:33:35 +0000 |
| commit | bc1407f95bae3d7472ee0c85ef83ee10610b3f1f (patch) | |
| tree | eeb1e01423fefc13afe5738d809df200b5e50623 /chrome/browser/views/star_toggle.cc | |
| parent | 62525634a6f5727216828f8e05a4f563be90dfeb (diff) | |
| download | chromium_src-bc1407f95bae3d7472ee0c85ef83ee10610b3f1f.zip chromium_src-bc1407f95bae3d7472ee0c85ef83ee10610b3f1f.tar.gz chromium_src-bc1407f95bae3d7472ee0c85ef83ee10610b3f1f.tar.bz2 | |
Relanding keyboard code refactoring:
http://codereview.chromium.org/248010/show
Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to several places where I had to switch from VK_ to VKEY_.
Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly.
BUG=None
TEST=Make sure short-cuts works as expected, especially in the omnibox.
Review URL: http://codereview.chromium.org/251020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27444 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/star_toggle.cc')
| -rw-r--r-- | chrome/browser/views/star_toggle.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/browser/views/star_toggle.cc b/chrome/browser/views/star_toggle.cc index 0e03f91..ebb67ac 100644 --- a/chrome/browser/views/star_toggle.cc +++ b/chrome/browser/views/star_toggle.cc @@ -6,6 +6,7 @@ #include "app/gfx/canvas.h" #include "app/resource_bundle.h" +#include "base/keyboard_codes.h" #include "chrome/app/chrome_dll_resource.h" #include "grit/theme_resources.h" @@ -63,7 +64,8 @@ void StarToggle::OnMouseReleased(const views::MouseEvent& e, } bool StarToggle::OnKeyPressed(const views::KeyEvent& e) { - if ((e.GetCharacter() == VK_SPACE) || (e.GetCharacter() == VK_RETURN)) { + if ((e.GetKeyCode() == base::VKEY_SPACE) || + (e.GetKeyCode() == base::VKEY_RETURN)) { SwitchState(); return true; } |