diff options
| author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-19 20:34:00 +0000 |
|---|---|---|
| committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-19 20:34:00 +0000 |
| commit | 186f13f42862926a39f452147004ef2861ba86e9 (patch) | |
| tree | fa8729baf71e17a023e953b4fb27d0671d12bef2 /chrome/browser/views/tab_contents | |
| parent | 06a277045d40f1cf1f6dbe86e6e1ed427bab4bdb (diff) | |
| download | chromium_src-186f13f42862926a39f452147004ef2861ba86e9.zip chromium_src-186f13f42862926a39f452147004ef2861ba86e9.tar.gz chromium_src-186f13f42862926a39f452147004ef2861ba86e9.tar.bz2 | |
Port more browser focus tests to linux.
Added a new test to make sure clicking sets focus, since I changed a lot of tests to programatically set focus instead of using clicking.
Also set the actual time on our synthetic key events. I'm still not sure this is necessary but would like to avoid subtle bugs.
Also get rid of the NineBox constructor that takes a theme provider and convert its callers to use cairo directly or the other NineBox constructor. This change was necessary because theme providers could go stale and then the NineBox would cause seg faults. Also, it was only being used for single images... and UniBox just sounds wrong.
Also fix extension shelf to paint its image with the correct x/y (noticeable only with certain themes). Remove the notification observer stuff from the extension shelf, as I don't think there is any action to be taken when the theme changes.
BUG=19076
BUG=19659
TEST=all the ported interactive ui tests (as well as all the already-working tests) pass.
TEST=(Linux) things still render correctly (frame image, drop shadows, find box, extension shelf)
Review URL: http://codereview.chromium.org/173030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23732 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/tab_contents')
| -rw-r--r-- | chrome/browser/views/tab_contents/native_tab_contents_container_win.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc b/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc index dad95e4..83db8e0 100644 --- a/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc +++ b/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc @@ -7,6 +7,7 @@ #include "chrome/browser/renderer_host/render_widget_host_view.h" #include "chrome/browser/tab_contents/interstitial_page.h" #include "chrome/browser/tab_contents/tab_contents.h" +#include "chrome/browser/view_ids.h" #include "chrome/browser/views/tab_contents/tab_contents_container.h" #include "chrome/browser/views/tab_contents/tab_contents_view_win.h" @@ -18,6 +19,7 @@ NativeTabContentsContainerWin::NativeTabContentsContainerWin( TabContentsContainer* container) : container_(container) { + SetID(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW); } NativeTabContentsContainerWin::~NativeTabContentsContainerWin() { |