summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/tabs
diff options
context:
space:
mode:
authorerg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-09-17 22:25:33 +0000
committererg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-09-17 22:25:33 +0000
commit6f3bb6ca5a2e423fc9dda71c164c7e8ae2a8eae7 (patch)
tree4ce1316dbfd179681bdff905a7d71f1b4cbb902c /chrome/browser/views/tabs
parent4c45708be10906e3cdbe9d40d206cfd3fcbaf1c2 (diff)
downloadchromium_src-6f3bb6ca5a2e423fc9dda71c164c7e8ae2a8eae7.zip
chromium_src-6f3bb6ca5a2e423fc9dda71c164c7e8ae2a8eae7.tar.gz
chromium_src-6f3bb6ca5a2e423fc9dda71c164c7e8ae2a8eae7.tar.bz2
Rename legacy methods that were in CamelCase to unix_hacker.
Required going through and modifying some of the code to solve name clashes. Review URL: http://codereview.chromium.org/2945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2337 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/tabs')
-rw-r--r--chrome/browser/views/tabs/tab.cc4
-rw-r--r--chrome/browser/views/tabs/tab_renderer.cc28
-rw-r--r--chrome/browser/views/tabs/tab_strip.cc46
3 files changed, 39 insertions, 39 deletions
diff --git a/chrome/browser/views/tabs/tab.cc b/chrome/browser/views/tabs/tab.cc
index ec2ec29..82bb795 100644
--- a/chrome/browser/views/tabs/tab.cc
+++ b/chrome/browser/views/tabs/tab.cc
@@ -218,8 +218,8 @@ void Tab::ButtonPressed(ChromeViews::BaseButton* sender) {
void Tab::MakePathForTab(gfx::Path* path) const {
DCHECK(path);
- SkScalar h = SkIntToScalar(GetHeight());
- SkScalar w = SkIntToScalar(GetWidth());
+ SkScalar h = SkIntToScalar(height());
+ SkScalar w = SkIntToScalar(width());
path->moveTo(0, h);
diff --git a/chrome/browser/views/tabs/tab_renderer.cc b/chrome/browser/views/tabs/tab_renderer.cc
index d7509ab..2dd430d 100644
--- a/chrome/browser/views/tabs/tab_renderer.cc
+++ b/chrome/browser/views/tabs/tab_renderer.cc
@@ -368,7 +368,7 @@ std::wstring TabRenderer::GetTitle() const {
void TabRenderer::Paint(ChromeCanvas* canvas) {
// Don't paint if we're narrower than we can render correctly. (This should
// only happen during animations).
- if (GetWidth() < GetMinimumSize().width())
+ if (width() < GetMinimumSize().width())
return;
// See if the model changes whether the icons should be painted.
@@ -389,7 +389,7 @@ void TabRenderer::Paint(ChromeCanvas* canvas) {
PaintLoadingAnimation(canvas);
} else {
canvas->save();
- canvas->ClipRectInt(0, 0, GetWidth(), GetHeight() - 4);
+ canvas->ClipRectInt(0, 0, width(), height() - 4);
if (should_display_crashed_favicon_) {
canvas->DrawBitmapInt(*crashed_fav_icon, 0, 0,
crashed_fav_icon->width(),
@@ -498,7 +498,7 @@ void TabRenderer::Layout() {
int title_width;
if (close_button_->IsVisible()) {
- title_width = std::max(close_button_->GetX() -
+ title_width = std::max(close_button_->x() -
kTitleCloseButtonSpacing - title_left, 0);
} else {
title_width = std::max(lb.Width() - title_left, 0);
@@ -580,17 +580,17 @@ void TabRenderer::PaintInactiveTabBackground(ChromeCanvas* canvas) {
canvas->DrawBitmapInt(is_otr ? *tab_inactive_otr_l : *tab_inactive_l, 0, 0);
canvas->TileImageInt(is_otr ? *tab_inactive_otr_c : *tab_inactive_c,
tab_inactive_l_width, 0,
- GetWidth() - tab_inactive_l_width - tab_inactive_r_width,
- GetHeight());
+ width() - tab_inactive_l_width - tab_inactive_r_width,
+ height());
canvas->DrawBitmapInt(is_otr ? *tab_inactive_otr_r : *tab_inactive_r,
- GetWidth() - tab_inactive_r_width, 0);
+ width() - tab_inactive_r_width, 0);
}
void TabRenderer::PaintActiveTabBackground(ChromeCanvas* canvas) {
canvas->DrawBitmapInt(*tab_active_l, 0, 0);
canvas->TileImageInt(*tab_active_c, tab_active_l_width, 0,
- GetWidth() - tab_active_l_width - tab_active_r_width, GetHeight());
- canvas->DrawBitmapInt(*tab_active_r, GetWidth() - tab_active_r_width, 0);
+ width() - tab_active_l_width - tab_active_r_width, height());
+ canvas->DrawBitmapInt(*tab_active_r, width() - tab_active_r_width, 0);
}
void TabRenderer::PaintHoverTabBackground(ChromeCanvas* canvas,
@@ -608,8 +608,8 @@ void TabRenderer::PaintHoverTabBackground(ChromeCanvas* canvas,
canvas->DrawBitmapInt(left, 0, 0);
canvas->TileImageInt(center, tab_active_l_width, 0,
- GetWidth() - tab_active_l_width - tab_active_r_width, GetHeight());
- canvas->DrawBitmapInt(right, GetWidth() - tab_active_r_width, 0);
+ width() - tab_active_l_width - tab_active_r_width, height());
+ canvas->DrawBitmapInt(right, width() - tab_active_r_width, 0);
}
void TabRenderer::PaintLoadingAnimation(ChromeCanvas* canvas) {
@@ -617,14 +617,14 @@ void TabRenderer::PaintLoadingAnimation(ChromeCanvas* canvas) {
waiting_animation_frames : loading_animation_frames;
int image_size = frames->height();
int image_offset = animation_frame_ * image_size;
- int dst_y = (GetHeight() - image_size) / 2;
+ int dst_y = (height() - image_size) / 2;
// Just like with the Tab's title and favicon, the position for the page
// loading animation also needs to be mirrored if the View's UI layout is
// right-to-left.
int dst_x;
if (UILayoutIsRightToLeft()) {
- dst_x = GetWidth() - kLeftPadding - image_size;
+ dst_x = width() - kLeftPadding - image_size;
} else {
dst_x = kLeftPadding;
}
@@ -634,10 +634,10 @@ void TabRenderer::PaintLoadingAnimation(ChromeCanvas* canvas) {
}
int TabRenderer::IconCapacity() const {
- if (GetHeight() < GetMinimumSize().height()) {
+ if (height() < GetMinimumSize().height()) {
return 0;
}
- return (GetWidth() - kLeftPadding - kRightPadding) / kFaviconSize;
+ return (width() - kLeftPadding - kRightPadding) / kFaviconSize;
}
bool TabRenderer::ShouldShowIcon() const {
diff --git a/chrome/browser/views/tabs/tab_strip.cc b/chrome/browser/views/tabs/tab_strip.cc
index 6182e9b..768604c 100644
--- a/chrome/browser/views/tabs/tab_strip.cc
+++ b/chrome/browser/views/tabs/tab_strip.cc
@@ -73,8 +73,8 @@ class NewTabButton : public ChromeViews::Button {
virtual void GetHitTestMask(gfx::Path* path) const {
DCHECK(path);
- SkScalar h = SkIntToScalar(GetHeight());
- SkScalar w = SkIntToScalar(GetWidth());
+ SkScalar h = SkIntToScalar(height());
+ SkScalar w = SkIntToScalar(width());
// These values are defined by the shape of the new tab bitmap. Should that
// bitmap ever change, these values will need to be updated. They're so
@@ -396,15 +396,15 @@ class MoveTabAnimation : public TabStrip::TabAnimation {
double distance = start_tab_b_bounds_.x() - start_tab_a_bounds_.x();
double delta = distance * animation_.GetCurrentValue();
double new_x = start_tab_a_bounds_.x() + delta;
- tab_a_->SetBounds(Round(new_x), tab_a_->GetY(), tab_a_->GetWidth(),
- tab_a_->GetHeight());
+ tab_a_->SetBounds(Round(new_x), tab_a_->y(), tab_a_->width(),
+ tab_a_->height());
// Position Tab B
distance = start_tab_a_bounds_.x() - start_tab_b_bounds_.x();
delta = distance * animation_.GetCurrentValue();
new_x = start_tab_b_bounds_.x() + delta;
- tab_b_->SetBounds(Round(new_x), tab_b_->GetY(), tab_b_->GetWidth(),
- tab_b_->GetHeight());
+ tab_b_->SetBounds(Round(new_x), tab_b_->y(), tab_b_->width(),
+ tab_b_->height());
tabstrip_->SchedulePaint();
}
@@ -470,9 +470,9 @@ class ResizeLayoutAnimation : public TabStrip::TabAnimation {
for (int i = 0; i < tabstrip_->GetTabCount(); ++i) {
Tab* current_tab = tabstrip_->GetTabAt(i);
if (current_tab->IsSelected()) {
- start_selected_width_ = current_tab->GetWidth();
+ start_selected_width_ = current_tab->width();
} else {
- start_unselected_width_ = current_tab->GetWidth();
+ start_unselected_width_ = current_tab->width();
}
}
}
@@ -624,8 +624,8 @@ void TabStrip::PaintChildren(ChromeCanvas* canvas) {
paint.setPorterDuffXfermode(SkPorterDuff::kDstIn_Mode);
paint.setStyle(SkPaint::kFill_Style);
canvas->FillRectInt(
- 0, 0, GetWidth(),
- GetHeight() - 2, // Visible region that overlaps the toolbar.
+ 0, 0, width(),
+ height() - 2, // Visible region that overlaps the toolbar.
paint);
}
@@ -1022,7 +1022,7 @@ void TabStrip::MaybeStartDrag(Tab* tab, const ChromeViews::MouseEvent& event) {
if (IsAnimating() || tab->closing())
return;
drag_controller_.reset(new DraggedTabController(tab, this));
- drag_controller_->CaptureDragInfo(gfx::Point(event.GetX(), event.GetY()));
+ drag_controller_->CaptureDragInfo(gfx::Point(event.x(), event.y()));
}
void TabStrip::ContinueDrag(const ChromeViews::MouseEvent& event) {
@@ -1171,7 +1171,7 @@ void TabStrip::GetDesiredTabWidths(int tab_count,
// Determine how much space we can actually allocate to tabs.
int available_width;
if (available_width_for_tabs_ < 0) {
- available_width = GetWidth();
+ available_width = width();
available_width -= (kNewTabButtonHOffset + newtab_button_size_.width());
} else {
// Interesting corner case: if |available_width_for_tabs_| > the result
@@ -1236,7 +1236,7 @@ void TabStrip::ResizeLayoutTabs() {
// We only want to run the animation if we're not already at the desired
// size.
- if (abs(first_tab->GetWidth() - w) > 1)
+ if (abs(first_tab->width() - w) > 1)
StartResizeLayoutAnimation();
}
@@ -1299,12 +1299,12 @@ gfx::Rect TabStrip::GetDropBounds(int drop_index,
if (drop_index < GetTabCount()) {
Tab* tab = GetTabAt(drop_index);
if (drop_before)
- center_x = tab->GetX() - (kTabHOffset / 2);
+ center_x = tab->x() - (kTabHOffset / 2);
else
- center_x = tab->GetX() + (tab->GetWidth() / 2);
+ center_x = tab->x() + (tab->width() / 2);
} else {
Tab* last_tab = GetTabAt(drop_index - 1);
- center_x = last_tab->GetX() + last_tab->GetWidth() + (kTabHOffset / 2);
+ center_x = last_tab->x() + last_tab->width() + (kTabHOffset / 2);
}
// Mirror the center point if necessary.
@@ -1321,7 +1321,7 @@ gfx::Rect TabStrip::GetDropBounds(int drop_index,
*is_beneath = (monitor_bounds.IsEmpty() ||
!monitor_bounds.Contains(drop_bounds));
if (*is_beneath)
- drop_bounds.Offset(0, drop_bounds.height() + GetHeight());
+ drop_bounds.Offset(0, drop_bounds.height() + height());
return drop_bounds;
}
@@ -1330,13 +1330,13 @@ void TabStrip::UpdateDropIndex(const DropTargetEvent& event) {
// If the UI layout is right-to-left, we need to mirror the mouse
// coordinates since we calculate the drop index based on the
// original (and therefore non-mirrored) positions of the tabs.
- const int x = MirroredXCoordinateInsideView(event.GetX());
+ const int x = MirroredXCoordinateInsideView(event.x());
for (int i = 0; i < GetTabCount(); ++i) {
Tab* tab = GetTabAt(i);
- const int tab_max_x = tab->GetX() + tab->GetWidth();
- const int hot_width = tab->GetWidth() / 3;
+ const int tab_max_x = tab->x() + tab->width();
+ const int hot_width = tab->width() / 3;
if (x < tab_max_x) {
- if (x < tab->GetX() + hot_width)
+ if (x < tab->x() + hot_width)
SetDropIndex(i, true);
else if (x >= tab_max_x - hot_width)
SetDropIndex(i + 1, true);
@@ -1465,7 +1465,7 @@ void TabStrip::LayoutNewTabButton(double last_tab_right,
// We're shrinking tabs, so we need to anchor the New Tab button to the
// right edge of the TabStrip's bounds, rather than the right edge of the
// right-most Tab, otherwise it'll bounce when animating.
- newtab_button_->SetBounds(GetWidth() - newtab_button_size_.width(),
+ newtab_button_->SetBounds(width() - newtab_button_size_.width(),
kNewTabButtonVOffset,
newtab_button_size_.width(),
newtab_button_size_.height());
@@ -1564,7 +1564,7 @@ int TabStrip::GetIndexOfTab(const Tab* tab) const {
}
int TabStrip::GetAvailableWidthForTabs(Tab* last_tab) const {
- return last_tab->GetX() + last_tab->GetWidth();
+ return last_tab->x() + last_tab->width();
}
bool TabStrip::IsPointInTab(Tab* tab, const CPoint& point_in_tabstrip_coords) {