summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/task_manager_view.cc
diff options
context:
space:
mode:
authorjamesr@chromium.org <jamesr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-25 17:59:03 +0000
committerjamesr@chromium.org <jamesr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-25 17:59:03 +0000
commitec9773681c979a58f966d6cb0fc8ad16746e3adf (patch)
tree2cbc893a1d4eb757b5bc9691351419d2eeceb007 /chrome/browser/views/task_manager_view.cc
parent1224e328aa1210ed5c194a5626479ac15519f3af (diff)
downloadchromium_src-ec9773681c979a58f966d6cb0fc8ad16746e3adf.zip
chromium_src-ec9773681c979a58f966d6cb0fc8ad16746e3adf.tar.gz
chromium_src-ec9773681c979a58f966d6cb0fc8ad16746e3adf.tar.bz2
Adds three new off-by-default columns to the task manager to track WebCore caches
These values are currently exposed via about:histograms/WebCoreCache. This change allows for users to monitor the cache sizes in real-time broken out by renderer. TEST=Open task manager, right click on chrome, select columns, observe that they update along with browsing. BUG=16221 Review URL: http://codereview.chromium.org/217010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27216 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/task_manager_view.cc')
-rw-r--r--chrome/browser/views/task_manager_view.cc24
1 files changed, 24 insertions, 0 deletions
diff --git a/chrome/browser/views/task_manager_view.cc b/chrome/browser/views/task_manager_view.cc
index 2a26896..5256b03 100644
--- a/chrome/browser/views/task_manager_view.cc
+++ b/chrome/browser/views/task_manager_view.cc
@@ -112,6 +112,15 @@ std::wstring TaskManagerTableModel::GetText(int row, int col_id) {
case IDS_TASK_MANAGER_GOATS_TELEPORTED_COLUMN: // Goats Teleported!
return model_->GetResourceGoatsTeleported(row);
+ case IDS_TASK_MANAGER_WEBCORE_IMAGE_CACHE_COLUMN:
+ return model_->GetResourceWebCoreImageCacheSize(row);
+
+ case IDS_TASK_MANAGER_WEBCORE_SCRIPTS_CACHE_COLUMN:
+ return model_->GetResourceWebCoreScriptsCacheSize(row);
+
+ case IDS_TASK_MANAGER_WEBCORE_CSS_CACHE_COLUMN:
+ return model_->GetResourceWebCoreCSSCacheSize(row);
+
default:
return model_->GetResourceStatsValue(row, col_id);
}
@@ -293,6 +302,15 @@ void TaskManagerView::Init() {
columns_.push_back(TableColumn(IDS_TASK_MANAGER_PROCESS_ID_COLUMN,
TableColumn::RIGHT, -1, 0));
columns_.back().sortable = true;
+ columns_.push_back(TableColumn(IDS_TASK_MANAGER_WEBCORE_IMAGE_CACHE_COLUMN,
+ TableColumn::RIGHT, -1, 0));
+ columns_.back().sortable = true;
+ columns_.push_back(TableColumn(IDS_TASK_MANAGER_WEBCORE_SCRIPTS_CACHE_COLUMN,
+ TableColumn::RIGHT, -1, 0));
+ columns_.back().sortable = true;
+ columns_.push_back(TableColumn(IDS_TASK_MANAGER_WEBCORE_CSS_CACHE_COLUMN,
+ TableColumn::RIGHT, -1, 0));
+ columns_.back().sortable = true;
tab_table_ = new views::GroupTableView(table_model_.get(), columns_,
views::ICON_AND_TEXT, false, true,
@@ -302,6 +320,12 @@ void TaskManagerView::Init() {
tab_table_->SetColumnVisibility(IDS_TASK_MANAGER_PROCESS_ID_COLUMN, false);
tab_table_->SetColumnVisibility(IDS_TASK_MANAGER_SHARED_MEM_COLUMN, false);
tab_table_->SetColumnVisibility(IDS_TASK_MANAGER_PRIVATE_MEM_COLUMN, false);
+ tab_table_->SetColumnVisibility(IDS_TASK_MANAGER_WEBCORE_IMAGE_CACHE_COLUMN,
+ false);
+ tab_table_->SetColumnVisibility(IDS_TASK_MANAGER_WEBCORE_SCRIPTS_CACHE_COLUMN,
+ false);
+ tab_table_->SetColumnVisibility(IDS_TASK_MANAGER_WEBCORE_CSS_CACHE_COLUMN,
+ false);
tab_table_->SetColumnVisibility(IDS_TASK_MANAGER_GOATS_TELEPORTED_COLUMN,
false);