diff options
| author | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-15 18:07:06 +0000 |
|---|---|---|
| committer | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-15 18:07:06 +0000 |
| commit | c74369a5288264e52355a940121cb09cebc633b5 (patch) | |
| tree | 231f742ba9ad7c68e6d3c035100157da4d556072 /chrome/browser/views/toolbar_star_toggle.h | |
| parent | 43448f9b2f1bad7df5dc408888322b639129142e (diff) | |
| download | chromium_src-c74369a5288264e52355a940121cb09cebc633b5.zip chromium_src-c74369a5288264e52355a940121cb09cebc633b5.tar.gz chromium_src-c74369a5288264e52355a940121cb09cebc633b5.tar.bz2 | |
Changes the bookmark bubble to have the following logic:
. We only apply edits when the bubble is closed (previously selecting
a different folder resulted in an immediate action).
. Hitting escape cancels any edits.
. When the bubble is shown for newly bookmarked items hitting escape
removes the bookmark.
. If you click 'Edit...' or select 'Choose another folder...' any
edits are applied immediately before the editor is shown.
BUG=5015
TEST=thorougly test the bookmark bubble to make sure I haven't broken
anything.
Review URL: http://codereview.chromium.org/14074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6991 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/toolbar_star_toggle.h')
| -rw-r--r-- | chrome/browser/views/toolbar_star_toggle.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/views/toolbar_star_toggle.h b/chrome/browser/views/toolbar_star_toggle.h index 9537506..0553894 100644 --- a/chrome/browser/views/toolbar_star_toggle.h +++ b/chrome/browser/views/toolbar_star_toggle.h @@ -43,7 +43,8 @@ class ToolbarStarToggle : public views::ToggleButton, private: // InfoBubbleDelegate. - virtual void InfoBubbleClosing(InfoBubble* info_bubble); + virtual void InfoBubbleClosing(InfoBubble* info_bubble, + bool closed_by_escape); virtual bool CloseOnEscape(); // Contains us. |