diff options
| author | stuartmorgan@chromium.org <stuartmorgan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-03 21:30:17 +0000 |
|---|---|---|
| committer | stuartmorgan@chromium.org <stuartmorgan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-03 21:30:17 +0000 |
| commit | 1b0c7f230fce9ee6024c03a1d23cdaec8cd949f4 (patch) | |
| tree | 447578f29456d41f85848b725369e73af4e7ed9c /chrome/browser/views | |
| parent | 5695dd36acba6750cdae8baa552d12cd6923a0ab (diff) | |
| download | chromium_src-1b0c7f230fce9ee6024c03a1d23cdaec8cd949f4.zip chromium_src-1b0c7f230fce9ee6024c03a1d23cdaec8cd949f4.tar.gz chromium_src-1b0c7f230fce9ee6024c03a1d23cdaec8cd949f4.tar.bz2 | |
Remove some test file complitation exceptions from chrome_tests.gypi
Adds bug annotation to the tests that still needs porting work.
BUG=45766,45753,45770,45771
TEST=Compling ui_tests still works
Review URL: http://codereview.chromium.org/2605001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48875 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views')
| -rw-r--r-- | chrome/browser/views/find_bar_host_uitest.cc | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/chrome/browser/views/find_bar_host_uitest.cc b/chrome/browser/views/find_bar_host_uitest.cc index 0cae5ab..fa54871 100644 --- a/chrome/browser/views/find_bar_host_uitest.cc +++ b/chrome/browser/views/find_bar_host_uitest.cc @@ -17,6 +17,11 @@ class FindInPageControllerTest : public UITest { const std::string kSimplePage = "404_is_enough_for_us.html"; +#if !defined(OS_WIN) +// Has never been enabled on other platforms http://crbug.com/45753 +#define FindMovesOnTabClose_Issue1343052 \ + DISABLED_FindMovesOnTabClose_Issue1343052 +#endif // The find window should not change its location just because we open and close // a new tab. TEST_F(FindInPageControllerTest, FindMovesOnTabClose_Issue1343052) { @@ -34,7 +39,7 @@ TEST_F(FindInPageControllerTest, FindMovesOnTabClose_Issue1343052) { ASSERT_TRUE(browser.get() != NULL); // Toggle the bookmark bar state. - browser->ApplyAccelerator(IDC_SHOW_BOOKMARK_BAR); + EXPECT_TRUE(browser->ApplyAccelerator(IDC_SHOW_BOOKMARK_BAR)); EXPECT_TRUE(WaitForBookmarkBarVisibilityChange(browser.get(), true)); // Open the Find window and wait for it to animate. @@ -61,7 +66,7 @@ TEST_F(FindInPageControllerTest, FindMovesOnTabClose_Issue1343052) { EXPECT_EQ(y, new_y); // Now reset the bookmark bar state and try the same again. - browser->ApplyAccelerator(IDC_SHOW_BOOKMARK_BAR); + EXPECT_TRUE(browser->ApplyAccelerator(IDC_SHOW_BOOKMARK_BAR)); EXPECT_TRUE(WaitForBookmarkBarVisibilityChange(browser.get(), false)); // Bookmark bar has moved, reset our coordinates. |