diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-30 15:22:45 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-30 15:22:45 +0000 |
| commit | 076bf500c06a2ec9ce9f5accc0eaad7c0b0b2666 (patch) | |
| tree | 90c75e38f905641cda5eff21273c76e9f80b4ca5 /chrome/browser/views | |
| parent | 09247ce046ae7fa18a868d7f07ad292899b3798c (diff) | |
| download | chromium_src-076bf500c06a2ec9ce9f5accc0eaad7c0b0b2666.zip chromium_src-076bf500c06a2ec9ce9f5accc0eaad7c0b0b2666.tar.gz chromium_src-076bf500c06a2ec9ce9f5accc0eaad7c0b0b2666.tar.bz2 | |
Cleanup in automation. Remove WaitForTabCountToChange.
WaitForTabCountToBecome is easier to use and more reliable.
Also removed Windows2000-specific code from accessibility unit tests.
Review URL: http://codereview.chromium.org/45070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12774 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views')
| -rw-r--r-- | chrome/browser/views/tabs/tab_dragging_test.cc | 26 |
1 files changed, 7 insertions, 19 deletions
diff --git a/chrome/browser/views/tabs/tab_dragging_test.cc b/chrome/browser/views/tabs/tab_dragging_test.cc index c0471c8..dba2765 100644 --- a/chrome/browser/views/tabs/tab_dragging_test.cc +++ b/chrome/browser/views/tabs/tab_dragging_test.cc @@ -56,12 +56,9 @@ TEST_F(TabDraggingTest, Tab1Tab2) { scoped_ptr<TabProxy> tab3(browser->GetTab(2)); ASSERT_TRUE(tab3.get()); - // Make sure 3 tabs are open - int final_tab_count = 0; - ASSERT_TRUE(browser->WaitForTabCountToChange(initial_tab_count, - &final_tab_count, + // Make sure 3 tabs are open. + ASSERT_TRUE(browser->WaitForTabCountToBecome(initial_tab_count + 2, 10000)); - ASSERT_TRUE(final_tab_count == initial_tab_count + 2); // Get bounds for the tabs. gfx::Rect bounds1; @@ -159,12 +156,9 @@ TEST_F(TabDraggingTest, Tab1Tab3) { scoped_ptr<TabProxy> tab3(browser->GetTab(2)); ASSERT_TRUE(tab3.get()); - // Make sure 3 tabs are open - int final_tab_count = 0; - ASSERT_TRUE(browser->WaitForTabCountToChange(initial_tab_count, - &final_tab_count, + // Make sure 3 tabs are open. + ASSERT_TRUE(browser->WaitForTabCountToBecome(initial_tab_count + 2, 10000)); - ASSERT_TRUE(final_tab_count == initial_tab_count + 2); // Get bounds for the tabs. gfx::Rect bounds1; @@ -269,12 +263,9 @@ TEST_F(TabDraggingTest, Tab1Tab3Escape) { scoped_ptr<TabProxy> tab3(browser->GetTab(2)); ASSERT_TRUE(tab3.get()); - // Make sure 3 tabs are open - int final_tab_count = 0; - ASSERT_TRUE(browser->WaitForTabCountToChange(initial_tab_count, - &final_tab_count, + // Make sure 3 tabs are open. + ASSERT_TRUE(browser->WaitForTabCountToBecome(initial_tab_count + 2, 10000)); - ASSERT_TRUE(final_tab_count == initial_tab_count + 2); // Get bounds for the tabs. gfx::Rect bounds1; @@ -383,11 +374,8 @@ TEST_F(TabDraggingTest, Tab2OutOfTabStrip) { ASSERT_TRUE(tab3.get()); // Make sure 3 tabs are opened. - int final_tab_count = 0; - ASSERT_TRUE(browser->WaitForTabCountToChange(initial_tab_count, - &final_tab_count, + ASSERT_TRUE(browser->WaitForTabCountToBecome(initial_tab_count + 2, 10000)); - ASSERT_TRUE(final_tab_count == initial_tab_count + 2); // Make sure all the tab URL specs are different. ASSERT_TRUE(tab1_url != tab2_url); |