Add a separate string for showing that chrome updated without

a version number. This makes it easier for translators to
handle both cases.

BUG=2656
Review URL: http://codereview.chromium.org/7900

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3821 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 9 insertions, 9 deletions

diff --git a/chrome/browser/views/about_chrome_view.cc b/chrome/browser/views/about_chrome_view.cc
index 1ef5292..e0ec434 100644
--- a/chrome/browser/views/about_chrome_view.cc
+++ b/chrome/browser/views/about_chrome_view.cc
@@ -610,11 +610,6 @@ void AboutChromeView::OnReportResults(GoogleUpdateUpgradeResult result,
   // Make a note of which version Google Update is reporting is the latest
   // version.
   new_version_available_ = version;
-  if (!new_version_available_.empty()) {
-    new_version_available_ = std::wstring(L"(") +
-                             new_version_available_ +
-                             std::wstring(L")");
-  }
   UpdateStatus(result, error_code);
 }
 
@@ -671,18 +666,23 @@ void AboutChromeView::UpdateStatus(GoogleUpdateUpgradeResult result,
       }
       // No break here as we want to notify user about upgrade if there is one.
     }
-    case UPGRADE_SUCCESSFUL:
+    case UPGRADE_SUCCESSFUL: {
       if (result == UPGRADE_ALREADY_UP_TO_DATE)
         UserMetrics::RecordAction(L"UpgradeCheck_AlreadyUpgraded", profile_);
       else
         UserMetrics::RecordAction(L"UpgradeCheck_Upgraded", profile_);
       check_button_status_ = CHECKBUTTON_HIDDEN;
-      update_label_.SetText(l10n_util::GetStringF(IDS_UPGRADE_SUCCESSFUL,
-          l10n_util::GetString(IDS_PRODUCT_NAME),
-          new_version_available_));
+      const std::wstring& update_string = new_version_available_.empty()
+          ? l10n_util::GetStringF(IDS_UPGRADE_SUCCESSFUL_NOVERSION,
+                                  l10n_util::GetString(IDS_PRODUCT_NAME))
+          : l10n_util::GetStringF(IDS_UPGRADE_SUCCESSFUL,
+                                  l10n_util::GetString(IDS_PRODUCT_NAME),
+                                  new_version_available_);
+      update_label_.SetText(update_string);
       show_success_indicator = true;
       RestartMessageBox::ShowMessageBox(window()->GetHWND());
       break;
+    }
     case UPGRADE_ERROR:
       UserMetrics::RecordAction(L"UpgradeCheck_Error", profile_);
       check_button_status_ = CHECKBUTTON_HIDDEN;