diff options
author | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-05 15:39:44 +0000 |
---|---|---|
committer | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-05 15:39:44 +0000 |
commit | 5a43397bd2e2fdceecf359a8430db0983fd3dba8 (patch) | |
tree | 0fd16a46f42548fd2a00e3c646846577e67a9c0b /chrome/browser/views | |
parent | 66d12ca5dad733c6d148509d2d145de1ef80ab14 (diff) | |
download | chromium_src-5a43397bd2e2fdceecf359a8430db0983fd3dba8.zip chromium_src-5a43397bd2e2fdceecf359a8430db0983fd3dba8.tar.gz chromium_src-5a43397bd2e2fdceecf359a8430db0983fd3dba8.tar.bz2 |
Fixes two bookmark manager bugs:
. Pressing enter when more than one folder is selected opens them all.
. Show in folder is only enabled when it makes sense: you've selected a
bookmark in the table and the table is showing recently bookmarked
or search results.
BUG=4034 4044
TEST=see bugs
Review URL: http://codereview.chromium.org/9367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4780 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views')
-rw-r--r-- | chrome/browser/views/bookmark_manager_view.cc | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/chrome/browser/views/bookmark_manager_view.cc b/chrome/browser/views/bookmark_manager_view.cc index 4cc816f..9650e92 100644 --- a/chrome/browser/views/bookmark_manager_view.cc +++ b/chrome/browser/views/bookmark_manager_view.cc @@ -436,20 +436,21 @@ void BookmarkManagerView::ShowMenu( (config == BookmarkContextMenu::BOOKMARK_MANAGER_ORGANIZE_MENU && table_view_->HasFocus())) { std::vector<BookmarkNode*> nodes = GetSelectedTableNodes(); - if (nodes.empty()) - return; - BookmarkNode* parent = GetSelectedFolder(); + if (!parent) { + if (config == BookmarkContextMenu::BOOKMARK_MANAGER_TABLE) + config = BookmarkContextMenu::BOOKMARK_MANAGER_TABLE_OTHER; + else + config = BookmarkContextMenu::BOOKMARK_MANAGER_ORGANIZE_MENU_OTHER; + } BookmarkContextMenu menu(host, profile_, NULL, NULL, parent, nodes, config); menu.RunMenuAt(x, y); } else { BookmarkNode* node = GetSelectedFolder(); - if (!node) - return; - std::vector<BookmarkNode*> nodes; - nodes.push_back(node); + if (node) + nodes.push_back(node); BookmarkContextMenu menu(GetContainer()->GetHWND(), profile_, NULL, NULL, node, nodes, config); menu.RunMenuAt(x, y); |