diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-08 23:20:20 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-08 23:20:20 +0000 |
| commit | a206b446481a9d522958a98e03912aba8c02bb4b (patch) | |
| tree | ef94c7d31020aaa871117fa1d23b352db34f0940 /chrome/browser/views | |
| parent | 96a41a0ec6889b5923a92454eafaf39fd63277cf (diff) | |
| download | chromium_src-a206b446481a9d522958a98e03912aba8c02bb4b.zip chromium_src-a206b446481a9d522958a98e03912aba8c02bb4b.tar.gz chromium_src-a206b446481a9d522958a98e03912aba8c02bb4b.tar.bz2 | |
* Add ctrl-shift-d to bookmark all tabs.
* Enable or disable bookmark commands based on whether we're actually going to be able to bookmark anything.
* Rename IDC_STAR to IDC_BOOKMARK_PAGE, which is more obvious.
BUG=2935
TEST=Hit ctrl-shift-d, make sure it bookmarks all tabs
Review URL: http://codereview.chromium.org/266029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28480 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views')
| -rw-r--r-- | chrome/browser/views/accelerator_table_gtk.cc | 2 | ||||
| -rw-r--r-- | chrome/browser/views/toolbar_view.cc | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/chrome/browser/views/accelerator_table_gtk.cc b/chrome/browser/views/accelerator_table_gtk.cc index 4a24493..25fbac7 100644 --- a/chrome/browser/views/accelerator_table_gtk.cc +++ b/chrome/browser/views/accelerator_table_gtk.cc @@ -98,7 +98,7 @@ const AcceleratorMapping kAcceleratorMap[] = { { base::VKEY_F5, true, false, false, IDC_RELOAD }, // Miscellany. - { base::VKEY_D, false, true, false, IDC_STAR }, + { base::VKEY_D, false, true, false, IDC_BOOKMARK_PAGE }, { base::VKEY_B, false, true, false, IDC_SHOW_BOOKMARK_BAR }, { base::VKEY_H, false, true, false, IDC_SHOW_HISTORY }, { base::VKEY_J, false, true, false, IDC_SHOW_DOWNLOADS }, diff --git a/chrome/browser/views/toolbar_view.cc b/chrome/browser/views/toolbar_view.cc index aedb65b..ef460c4 100644 --- a/chrome/browser/views/toolbar_view.cc +++ b/chrome/browser/views/toolbar_view.cc @@ -167,7 +167,7 @@ ToolbarView::ToolbarView(Browser* browser) browser_->command_updater()->AddCommandObserver(IDC_FORWARD, this); browser_->command_updater()->AddCommandObserver(IDC_RELOAD, this); browser_->command_updater()->AddCommandObserver(IDC_HOME, this); - browser_->command_updater()->AddCommandObserver(IDC_STAR, this); + browser_->command_updater()->AddCommandObserver(IDC_BOOKMARK_PAGE, this); if (browser->type() == Browser::TYPE_NORMAL) display_mode_ = DISPLAYMODE_NORMAL; else @@ -329,7 +329,7 @@ void ToolbarView::EnabledStateChangedForCommand(int id, bool enabled) { case IDC_HOME: button = home_; break; - case IDC_STAR: + case IDC_BOOKMARK_PAGE: button = star_; break; } @@ -831,7 +831,7 @@ void ToolbarView::CreateLeftSideControls() { void ToolbarView::CreateCenterStack(Profile *profile) { star_ = new ToolbarStarToggle(this, this); - star_->set_tag(IDC_STAR); + star_->set_tag(IDC_BOOKMARK_PAGE); star_->SetDragController(this); star_->SetTooltipText(l10n_util::GetString(IDS_TOOLTIP_STAR)); star_->SetToggledTooltipText(l10n_util::GetString(IDS_TOOLTIP_STARRED)); |