summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
diff options
context:
space:
mode:
authorphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-07-30 23:20:32 +0000
committerphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-07-30 23:20:32 +0000
commiteb210d2cbe6e3dc88140bb8d53a9b02955fa5858 (patch)
treede2e30862772bc9ea70db62c6220ca01e43c85a4 /chrome/browser/views
parent8f05f7f2ef3eddee9a305d5c40b315ac767f44c5 (diff)
downloadchromium_src-eb210d2cbe6e3dc88140bb8d53a9b02955fa5858.zip
chromium_src-eb210d2cbe6e3dc88140bb8d53a9b02955fa5858.tar.gz
chromium_src-eb210d2cbe6e3dc88140bb8d53a9b02955fa5858.tar.bz2
GTTF: Add more logging to BrowserKeyboardAccessibility test
to help debug hangs and crashes. Using LOG(ERROR) to make sure the output will be always visible and captured on Windows. We need the logs. The issue is hard to reproduce. TEST=BrowserKeyboardAccessibility BUG=50663 Review URL: http://codereview.chromium.org/3071011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54404 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views')
-rw-r--r--chrome/browser/views/browser_keyboard_accessibility_test_win.cc18
1 files changed, 18 insertions, 0 deletions
diff --git a/chrome/browser/views/browser_keyboard_accessibility_test_win.cc b/chrome/browser/views/browser_keyboard_accessibility_test_win.cc
index c1ad34d..4aab19c 100644
--- a/chrome/browser/views/browser_keyboard_accessibility_test_win.cc
+++ b/chrome/browser/views/browser_keyboard_accessibility_test_win.cc
@@ -35,6 +35,9 @@ class BrowserKeyboardAccessibility : public InProcessBrowserTest,
current_event_type_ = event_type;
// Are we within a message loop waiting for a particular event?
+ // TODO(phajdan.jr): remove logging after fixing http://crbug.com/50663.
+ LOG(ERROR) << "Got notification; is_waiting_ is "
+ << (is_waiting_ ? "true" : "false");
if (is_waiting_) {
is_waiting_ = false;
MessageLoop::current()->Quit();
@@ -98,7 +101,14 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyboardAccessibility, TabInOptionsDialog) {
// Tab through each of the three tabs.
for (int i = 0; i < 3; ++i) {
+ // TODO(phajdan.jr): remove logging after fixing http://crbug.com/50663.
+ LOG(ERROR) << "Iteration no. " << i;
+
TabCyclerForwardAndBack(current_view_native_window());
+
+
+ // TODO(phajdan.jr): remove logging after fixing http://crbug.com/50663.
+ LOG(ERROR) << "Sending TAB key event...";
ui_controls::SendKeyPressNotifyWhenDone(current_view_native_window(),
base::VKEY_TAB,
true, false, false, false,
@@ -152,9 +162,13 @@ void BrowserKeyboardAccessibility::TabCycler(gfx::NativeWindow hwnd,
// Wait for a focus event on the provided native window.
while (current_event() != AccessibilityTypes::EVENT_FOCUS ||
current_view_native_window() != hwnd) {
+ // TODO(phajdan.jr): remove logging after fixing http://crbug.com/50663.
+ LOG(ERROR) << "Runnig message loop...";
set_waiting(true);
ui_test_utils::RunMessageLoop();
}
+ // TODO(phajdan.jr): remove logging after fixing http://crbug.com/50663.
+ LOG(ERROR) << "After the loop.";
views::View* first_focused_item = current_view();
@@ -164,12 +178,16 @@ void BrowserKeyboardAccessibility::TabCycler(gfx::NativeWindow hwnd,
// Keep tabbing until we reach the originally focused view.
do {
+ // TODO(phajdan.jr): remove logging after fixing http://crbug.com/50663.
+ LOG(ERROR) << "Sending TAB key event.";
ui_controls::SendKeyPressNotifyWhenDone(hwnd, base::VKEY_TAB,
false, !forward_tab, false, false, new MessageLoop::QuitTask());
set_waiting(true);
ui_test_utils::RunMessageLoop();
next_focused_item = current_view();
} while (first_focused_item != next_focused_item);
+ // TODO(phajdan.jr): remove logging after fixing http://crbug.com/50663.
+ LOG(ERROR) << "After second loop.";
}
} // namespace