diff options
| author | idanan@google.com <idanan@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-13 19:28:53 +0000 |
|---|---|---|
| committer | idanan@google.com <idanan@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-13 19:28:53 +0000 |
| commit | 06dd50ea9d8bda2e9109e79930fdda7fa2942827 (patch) | |
| tree | abc2cb7bfdb0b8970862a8476ba6927553f1215e /chrome/browser/views | |
| parent | e0ea6b42f5d8a4dc701ce2e42943765b9068e7d8 (diff) | |
| download | chromium_src-06dd50ea9d8bda2e9109e79930fdda7fa2942827.zip chromium_src-06dd50ea9d8bda2e9109e79930fdda7fa2942827.tar.gz chromium_src-06dd50ea9d8bda2e9109e79930fdda7fa2942827.tar.bz2 | |
Originally this change was intended as the solution to accidentally maximizing Chrome by double-clicking on the new tab button. This solution does work but another one is being coded for a more general problem. This change solves also the accidental maximizing of Chrome when double-clicking the close tab button except on the last tab (rightmost in LTR systems). See issue 2827 for further details.This change removes a band-aid which did not perform a hit-test on the tab-strip while it is animating in order to avoid unknown chromebot crashes as reported by Ben. The removal of the fix makes the hit-test perform as expected.Trying this now, at Peter's suggestion, so that we can measure and diagnose potential problems hidden by the said band-aid.
[NOTE]
Revied and approved as http://codereview.chromium.org/20329
by Peter kasting. Had to copy changes to repo where I have
commit rights.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9777 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views')
| -rw-r--r-- | chrome/browser/views/frame/browser_view.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/chrome/browser/views/frame/browser_view.cc b/chrome/browser/views/frame/browser_view.cc index 5d7059e..b262967 100644 --- a/chrome/browser/views/frame/browser_view.cc +++ b/chrome/browser/views/frame/browser_view.cc @@ -977,9 +977,8 @@ int BrowserView::NonClientHitTest(const gfx::Point& point) { } // Determine if the TabStrip exists and is capable of being clicked on. We - // might be a popup window without a TabStrip, or the TabStrip could be - // animating. - if (IsTabStripVisible() && tabstrip_->CanProcessInputEvents()) { + // might be a popup window without a TabStrip. + if (IsTabStripVisible()) { gfx::Point point_in_view_coords(point); View::ConvertPointToView(GetParent(), this, &point_in_view_coords); |