diff options
| author | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-27 01:16:20 +0000 |
|---|---|---|
| committer | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-27 01:16:20 +0000 |
| commit | 768336c46a3740caa5716e4a6edcf6e7c03d1d9b (patch) | |
| tree | 05461829f0eda2f5ba946fc4e5afce5db45d13b1 /chrome/browser/views | |
| parent | c1ab43dc83a615dfbf4b5153f2bfc9abee8871c2 (diff) | |
| download | chromium_src-768336c46a3740caa5716e4a6edcf6e7c03d1d9b.zip chromium_src-768336c46a3740caa5716e4a6edcf6e7c03d1d9b.tar.gz chromium_src-768336c46a3740caa5716e4a6edcf6e7c03d1d9b.tar.bz2 | |
This CL fix issue 5724 - RTL: Windows context menu with Alt+Space Bar should be displayed on right side of the window.
(http://crbug.com/5724)
and issue 5738 - RTL: App drop-down menu should be displayed below the favicon
(http://crbug.com/5738)
In RTL UI, the x-axis of the system menu was computed as the MirroredXCoordinateInsideView(x-axis in LTR UI);
Also, the menu was right-aligned relative to the x-axis.
It fixes the system menu position in the following 3 situations:
1. press alt+space (such as in application short-cut, in chrome browser, in pop-up dialog such as option/clear browsing data), the system menu appears on the right side of the window (instead of left side, without the fix).
2. click favicon of application shortcut, the system menu appears on the right side of the window (instead of left side, without the fix).
3. right click on chrome browser tab, system menu appears at
left side of the click (instead of right side of the click).
Please be noted that:
System menu itself is not yet mirrored. This CL only fixes its display position.
Review URL: http://codereview.chromium.org/53120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12631 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views')
| -rw-r--r-- | chrome/browser/views/frame/opaque_browser_frame_view.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/views/frame/opaque_browser_frame_view.cc b/chrome/browser/views/frame/opaque_browser_frame_view.cc index e2093f8..0f6c244 100644 --- a/chrome/browser/views/frame/opaque_browser_frame_view.cc +++ b/chrome/browser/views/frame/opaque_browser_frame_view.cc @@ -460,7 +460,8 @@ gfx::Rect OpaqueBrowserFrameView::GetWindowBoundsForClientBounds( } gfx::Point OpaqueBrowserFrameView::GetSystemMenuPoint() const { - gfx::Point system_menu_point(FrameBorderThickness(), + gfx::Point system_menu_point( + MirroredXCoordinateInsideView(FrameBorderThickness()), NonClientTopBorderHeight() + browser_view_->GetTabStripHeight() - (browser_view_->IsFullscreen() ? 0 : kClientEdgeThickness)); ConvertPointToScreen(this, &system_menu_point); |