diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-17 00:12:52 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-17 00:12:52 +0000 |
commit | 1a98a93fc1977683c3789dedbef2806b3fcdf5b4 (patch) | |
tree | 4a8b6aa1e55e0d2d93e9f646f3bdde3aaa98cab4 /chrome/browser/views | |
parent | f09d9379d6e654e7fd95b9d601b1e77f1ac13c3d (diff) | |
download | chromium_src-1a98a93fc1977683c3789dedbef2806b3fcdf5b4.zip chromium_src-1a98a93fc1977683c3789dedbef2806b3fcdf5b4.tar.gz chromium_src-1a98a93fc1977683c3789dedbef2806b3fcdf5b4.tar.bz2 |
amit, please review everything, jam please review the changes to the tab_contents and the
renderer_host sources.
Remove the AutomationProfileImpl class which wraps the Chrome profile for an external tab
container, which hosts ChromeFrame. This object was used to carry a custom URL request
context which was used to intercept HTTP requests and cookie requests issued by external
tabs.
However as the life time of the automation profile class depended on the lifetime of the external
tab container object this caused a number of crashes in objects which held on to the automation profile
pointer retrieved from the associated tab contents. This does not happen in a regualar Chrome browser
instance as the profile is deleted at the very end.
We can associate the automation URL request context with the underlying tab_contents which would
eventually percolate down to the resource message filter. Doing this would avoid the need for the
AutomationProfile class.
This CL achieves that.
Bug=27695,27662
Review URL: http://codereview.chromium.org/385117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32127 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views')
-rw-r--r-- | chrome/browser/views/notifications/balloon_view_host.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/views/notifications/balloon_view_host.cc b/chrome/browser/views/notifications/balloon_view_host.cc index fa8e842..9bef667 100644 --- a/chrome/browser/views/notifications/balloon_view_host.cc +++ b/chrome/browser/views/notifications/balloon_view_host.cc @@ -104,7 +104,7 @@ void BalloonViewHost::Init(gfx::NativeView parent_hwnd) { #endif // Start up the renderer and point it at the balloon contents URL. - rvh->CreateRenderView(); + rvh->CreateRenderView(GetProfile()->GetRequestContext()); rvh->NavigateToURL(balloon_->notification().content_url()); initialized_ = true; } |