diff options
| author | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-06 16:26:23 +0000 |
|---|---|---|
| committer | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-06 16:26:23 +0000 |
| commit | a11a3e29a210a444648fe731bd4cbcc2e876d759 (patch) | |
| tree | 24aaa501af1303ae965eec3e87f419c2b484d32c /chrome/browser/views | |
| parent | e90837d525e33abb26e65bd75fdb54ead15fe95c (diff) | |
| download | chromium_src-a11a3e29a210a444648fe731bd4cbcc2e876d759.zip chromium_src-a11a3e29a210a444648fe731bd4cbcc2e876d759.tar.gz chromium_src-a11a3e29a210a444648fe731bd4cbcc2e876d759.tar.bz2 | |
Ensure that status bubble does not obscure download shelf.
BUG= http://crbug.com/18425
TEST= Cause download shelf to appear. Hover over a link in the extreme lower left corner of the page. Note that status bubble dodges to the right, instead of dropping to obscure the shelf.
Review URL: http://codereview.chromium.org/159878
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22610 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views')
| -rw-r--r-- | chrome/browser/views/frame/browser_view.cc | 13 | ||||
| -rw-r--r-- | chrome/browser/views/status_bubble_views.cc | 3 |
2 files changed, 7 insertions, 9 deletions
diff --git a/chrome/browser/views/frame/browser_view.cc b/chrome/browser/views/frame/browser_view.cc index b85fec0..e1fbe6a 100644 --- a/chrome/browser/views/frame/browser_view.cc +++ b/chrome/browser/views/frame/browser_view.cc @@ -871,15 +871,12 @@ void BrowserView::SetDownloadShelfVisible(bool visible) { if (browser_ == NULL) return; - if (IsDownloadShelfVisible() != visible) { - if (visible) { - // Invoke GetDownloadShelf to force the shelf to be created. - GetDownloadShelf(); - } + if (visible && IsDownloadShelfVisible() != visible) + // Invoke GetDownloadShelf to force the shelf to be created. + GetDownloadShelf(); - if (browser_ != NULL) - browser_->UpdateDownloadShelfVisibility(visible); - } + if (browser_ != NULL) + browser_->UpdateDownloadShelfVisibility(visible); // SetDownloadShelfVisible can force-close the shelf, so make sure we lay out // everything correctly, as if the animation had finished. This doesn't diff --git a/chrome/browser/views/status_bubble_views.cc b/chrome/browser/views/status_bubble_views.cc index e6a03b9..439e938 100644 --- a/chrome/browser/views/status_bubble_views.cc +++ b/chrome/browser/views/status_bubble_views.cc @@ -632,7 +632,8 @@ void StatusBubbleViews::AvoidMouse() { if (bubble_bottom_y + offset > monitor_rect.height() || (download_shelf_is_visible_ && - view_->GetStyle() == StatusView::STYLE_FLOATING)) { + (view_->GetStyle() == StatusView::STYLE_FLOATING || + view_->GetStyle() == StatusView::STYLE_BOTTOM))) { // The offset is still too large. Move the bubble to the right and reset // Y offset_ to zero. view_->SetStyle(StatusView::STYLE_STANDARD_RIGHT); |