diff options
| author | glen@chromium.org <glen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-30 23:51:39 +0000 |
|---|---|---|
| committer | glen@chromium.org <glen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-30 23:51:39 +0000 |
| commit | f64dcdade2021bf7e6093935fdc3eee5ccd1ecdf (patch) | |
| tree | 3d2ba79b3a070362849a8c44783324940ae412d7 /chrome/browser/web_contents.cc | |
| parent | 1057da7cbd8fe6257c667f346001b7e59902ea12 (diff) | |
| download | chromium_src-f64dcdade2021bf7e6093935fdc3eee5ccd1ecdf.zip chromium_src-f64dcdade2021bf7e6093935fdc3eee5ccd1ecdf.tar.gz chromium_src-f64dcdade2021bf7e6093935fdc3eee5ccd1ecdf.tar.bz2 | |
Fix for HTTP AUTH prompts allowing save-password infobars to be shown after a transition away from the appropriate page while that page was loading.
The issue was the LoginPrompt set up a provisional password save prior to the start of a page load, and DidNavigate is not called early enough when a user navigates, which they have an opportunity to do in the HTTP auth case (details in bug comments).
BUG=2792
Review URL: http://codereview.chromium.org/8647
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4250 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/web_contents.cc')
| -rw-r--r-- | chrome/browser/web_contents.cc | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/chrome/browser/web_contents.cc b/chrome/browser/web_contents.cc index 50ec3cd..fe35c73 100644 --- a/chrome/browser/web_contents.cc +++ b/chrome/browser/web_contents.cc @@ -371,6 +371,11 @@ bool WebContents::NavigateToPendingEntry(bool reload) { return false; } + // Clear any provisional password saves - this stops password infobars + // showing up on pages the user navigates to while the right page is + // loading. + GetPasswordManager()->ClearProvisionalSave(); + if (reload && !profile()->IsOffTheRecord()) { HistoryService* history = profile()->GetHistoryService(Profile::IMPLICIT_ACCESS); |