Move RenderViewHost management out of WebContents into a new

RenderViewHostManager object.

The goal for this patch is to change no logic or APIs, just move the code. So
there are some not very clean callback functions and no new unit tests for this
file (although is is still covered by the same WebContents unit tests). This
should make the actual cleanup in a later pass much easier to follow.

I changed the ordering of only a few operations (like WebContents shutdown), and checked that this shouldn't matter. I had to change the "source" for several notifications since they are no longer sent from the WebContents.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@716 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 4 insertions, 4 deletions

diff --git a/chrome/browser/web_drop_target.cc b/chrome/browser/web_drop_target.cc
index f107d95..aa4dd10 100644
--- a/chrome/browser/web_drop_target.cc
+++ b/chrome/browser/web_drop_target.cc
@@ -116,7 +116,7 @@ DWORD WebDropTarget::OnDragEnter(IDataObject* data_object,
   // Don't pass messages to the renderer if an interstitial page is showing
   // because we don't want the interstitial page to navigate.  Instead,
   // pass the messages on to a separate interstitial DropTarget handler.
-  if (web_contents_->IsShowingInterstitialPage())
+  if (web_contents_->showing_interstitial_page())
     return interstitial_drop_target_->OnDragEnter(data_object, effect);
 
   // TODO(tc): PopulateWebDropData is kind of slow, maybe we can do this in a
@@ -144,7 +144,7 @@ DWORD WebDropTarget::OnDragOver(IDataObject* data_object,
                                 DWORD key_state,
                                 POINT cursor_position,
                                 DWORD effect) {
-  if (web_contents_->IsShowingInterstitialPage())
+  if (web_contents_->showing_interstitial_page())
     return interstitial_drop_target_->OnDragOver(data_object, effect);
 
   POINT client_pt = cursor_position;
@@ -160,7 +160,7 @@ DWORD WebDropTarget::OnDragOver(IDataObject* data_object,
 }
 
 void WebDropTarget::OnDragLeave(IDataObject* data_object) {
-  if (web_contents_->IsShowingInterstitialPage()) {
+  if (web_contents_->showing_interstitial_page()) {
     interstitial_drop_target_->OnDragLeave(data_object);
   } else {
     web_contents_->DragTargetDragLeave();
@@ -172,7 +172,7 @@ DWORD WebDropTarget::OnDrop(IDataObject* data_object,
                             DWORD key_state,
                             POINT cursor_position,
                             DWORD effect) {
-  if (web_contents_->IsShowingInterstitialPage())
+  if (web_contents_->showing_interstitial_page())
     return interstitial_drop_target_->OnDrop(data_object, effect);
 
   POINT client_pt = cursor_position;